gh-94924: support inspect.iscoroutinefunction in create_autospec(async_def)#94962
Uh oh!
There was an error while loading. Please reload this page.
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
ContributorAuthor
graingert commented Jul 18, 2022
see also #84753 |
graingertforce-pushed the mock-create-autospec-async-def branch from cd43e01 to e0424d2Compare
graingert commented Jul 18, 2022
Uh oh!
There was an error while loading. Please reload this page.
graingertforce-pushed the mock-create-autospec-async-def branch from ccd885e to 034f947Compare
cjw296 approved these changes Jun 9, 2023
cjw296 reviewed Jul 10, 2023
Uh oh!
There was an error while loading. Please reload this page.
cjw296 reviewed Jul 10, 2023
Uh oh!
There was an error while loading. Please reload this page.
Member
hugovk commented Mar 15, 2024
@cjw296 Should this be backported to 3.12 and 3.11, or can the issue be closed? |
Contributor
cjw296 commented Mar 18, 2024
I think the issue can be closed, if folks need this in 3.12 or 3.11 they can comment here and I'll crank the handle to get it into the backport release on pypi. |
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
unitest.mock.create_autospec(async_def)does not create functions valid forinspect.iscoroutinefunction#94924