gh-95335: extract 'struct cfg_builder' from the compiler so that the CFG can be manipulated directly#95107
Uh oh!
There was an error while loading. Please reload this page.
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
…G can be manipulated directly
iritkatriel added skip news interpreter-core iritkatriel added the 🔨 test-with-buildbots 
bedevere-bot commented Jul 21, 2022
🤖 New build scheduled with the buildbot fleet by @iritkatriel for commit 4bbebf8 🤖 If you want to schedule another build, you need to add the ":hammer: test-with-buildbots" label again. |
bedevere-bot removed the 🔨 test-with-buildbots Uh oh!
There was an error while loading. Please reload this page.
iritkatriel changed the title 
MemberAuthor
iritkatriel commented Jul 26, 2022
@markshannon Any more comments on this? |
markshannon approved these changes Jul 26, 2022
Member
markshannon left a comment
markshannon left a comment There was a problem hiding this comment.
FTR, I'd prefer we pass locations by value, but no need to do that for this PR.
MemberAuthor
iritkatriel commented Jul 26, 2022
Sure, might as well do it here. |
iritkatriel changed the title Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This further decouples the compiler struct from parts of the compilation process, and in particular enables CFG construction without a compiler (which is useful for unit tests).