gh-95166: cancel map waited on future on timeout#95169

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged

ambv merged 8 commits into python:main from graingert:cancel-map-future-on-timeout

Jul 28, 2022

Contributor

graingert commented Jul 23, 2022•
edited by bedevere-bot
Loading

Issue: concurrent.futures.Executor.map does not cancel the currently waited on future #95166

pythongh-95166: cancel map waited on future on timeout

c2abb04

bedevere-bot added the awaiting review label

📜🤖 Added by blurb_it.

b305705

graingert commented

View reviewed changes

Lib/test/test_concurrent_futures.py Outdated Show resolvedHide resolved

graingert added 2 commits

July 23, 2022 11:47

Update Lib/test/test_concurrent_futures.py

5638c0a

Merge branch 'main' into cancel-map-future-on-timeout

89bda6c

graingert commented

View reviewed changes

Lib/test/test_concurrent_futures.py Outdated Show resolvedHide resolved

Update Lib/test/test_concurrent_futures.py

030a7cc

graingert commented

View reviewed changes

Lib/test/test_concurrent_futures.pyShow resolvedHide resolved

graingert commented

View reviewed changes

Lib/test/test_concurrent_futures.py Outdated Show resolvedHide resolved

Apply suggestions from code review

f54eadf

graingert commented

View reviewed changes

Lib/test/test_concurrent_futures.py Outdated Show resolvedHide resolved

Update Lib/test/test_concurrent_futures.py

2b75518

graingert marked this pull request as ready for review

July 23, 2022 19:15

graingert requested a review from kumaraditya303

July 23, 2022 19:15

kumaraditya303 approved these changes

View reviewed changes

Contributor

kumaraditya303 left a comment

LGTM

bedevere-bot added awaiting core review and removed awaiting review labels

kumaraditya303 reviewed

View reviewed changes

Misc/NEWS.d/next/Library/2022-07-23-10-42-05.gh-issue-95166.xw6p3C.rst Outdated Show resolvedHide resolved

kumaraditya303 added type-bug needs backport to 3.10 needs backport to 3.11 labels

Update Misc/NEWS.d/next/Library/2022-07-23-10-42-05.gh-issue-95166.xw…

f5b7372

…6p3C.rst Co-authored-by: Kumar Aditya <[email protected]>

ambv self-requested a review

July 26, 2022 10:29

ambv merged commit e16d4ed into python:main

Contributor

miss-islington commented Jul 28, 2022

Thanks @graingert for the PR, and @ambv for merging it 🌮🎉.. I'm working now to backport this PR to: 3.10, 3.11.
🐍🍒⛏🤖

bedevere-bot removed the awaiting core review label

miss-islington pushed a commit to miss-islington/cpython that referenced this pull request

pythongh-95166: cancel map waited on future on timeout (pythonGH-95169)

e789fb7

Co-authored-by: Kumar Aditya <[email protected]> (cherry picked from commit e16d4ed) Co-authored-by: Thomas Grainger <[email protected]>

bedevere-bot commented Jul 28, 2022

GH-95364 is a backport of this pull request to the 3.11 branch.

bedevere-bot removed the needs backport to 3.11 label

miss-islington pushed a commit to miss-islington/cpython that referenced this pull request

pythongh-95166: cancel map waited on future on timeout (pythonGH-95169)

a4ca7fb

Co-authored-by: Kumar Aditya <[email protected]> (cherry picked from commit e16d4ed) Co-authored-by: Thomas Grainger <[email protected]>

bedevere-bot commented Jul 28, 2022•
edited by ambv
Loading

~~GH-95365 is a backport of this pull request to the 3.10 branch.~~

#95375 is the backport of this pull request to the 3.10 branch.

bedevere-bot removed the needs backport to 3.10 label

ambv pushed a commit that referenced this pull request

gh-95166: cancel map waited on future on timeout (GH-95169) (GH-95364)

763801a

Co-authored-by: Kumar Aditya <[email protected]> (cherry picked from commit e16d4ed) Co-authored-by: Thomas Grainger <[email protected]>

ambv pushed a commit to ambv/cpython that referenced this pull request

pythongh-95166: cancel map waited on future on timeout (pythonGH-95169)

f1f0f9a

Co-authored-by: Kumar Aditya <[email protected]>

graingert deleted the cancel-map-future-on-timeout branch

July 28, 2022 21:02

ambv added a commit that referenced this pull request

[3.10]gh-95166: cancel map waited on future on timeout (GH-95169) (G…

1841885

…H-95375) Co-authored-by: Thomas Grainger <[email protected]> Co-authored-by: Kumar Aditya <[email protected]>

This was referenced Mar 23, 2025

gh-131466: concurrent.futures.Executor.map: avoid temporarily exceeding buffersize while collecting the next result #131467

Open

gh-74028: concurrent.futures.Executor.map: avoid reference cycles when an exception is raised #131701

Open

Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment