gh-95041: Fail syslog.syslog in case inner call to syslog.openlog fails

[noamcohen97]

• Issue: syslog issues #95041

[bedevere-bot]

Most changes to Python require a NEWS entry.

Please add it using the blurb_it web app or the blurb command-line tool.

[bedevere-bot]

Most changes to Python require a NEWS entry.

Please add it using the blurb_it web app or the blurb command-line tool.

[bedevere-bot]

Most changes to Python require a NEWS entry.

Please add it using the blurb_it web app or the blurb command-line tool.

[bedevere-bot]

Most changes to Python require a NEWS entry.

Please add it using the blurb_it web app or the blurb command-line tool.

[bedevere-bot]

Most changes to Python require a NEWS entry.

Please add it using the blurb_it web app or the blurb command-line tool.

[erlend-aasland]

LGTM. Thanks, Noam!

[erlend-aasland]

The only remaining issue, is that I'd like a NEWS entry that covers both this PR and Serhiy's PR. I don't think fixing this qualifies for skip news. Serhiy?

[serhiy-storchaka]

At first I thought that these are rather theoretical bugs that do not manifest themselves in the real world, or the effect of which is insignificant. Later I realized that it is possible that these bugs can lead to a crash if syslog.openlog(), syslog.syslog() and syslog.closelog() are used in a multi-threaded program. And I was in such a hurry to merge #95058 to unlock #95011 that I forgot to add a NEWS entry. I still does not have a reproducer to confirm that it is a realistic danger. Maybe I'll add a NEWS entry later, maybe with some tests, if they are not too burdensome.

[erlend-aasland]

Ok, I'm fine with that. Let's land this :)

[miss-islington]

Thanks @noamcohen97 for the PR, and @serhiy-storchaka for merging it 🌮🎉.. I'm working now to backport this PR to: 3.10, 3.11.
🐍🍒⛏🤖

[miss-islington]

Sorry @noamcohen97 and @serhiy-storchaka, I had trouble checking out the 3.11 backport branch.
Please backport using cherry_picker on command line.
cherry_picker b1f648efc56ff17e18ec2b7402d59a771b305004 3.11

[bedevere-bot]

GH-95275 is a backport of this pull request to the 3.10 branch.

[miss-islington]

Thanks @noamcohen97 for the PR, and @serhiy-storchaka for merging it 🌮🎉.. I'm working now to backport this PR to: 3.11.
🐍🍒⛏🤖

[bedevere-bot]

GH-95277 is a backport of this pull request to the 3.11 branch.

[bedevere-bot]

⚠️⚠️⚠️ Buildbot failure ⚠️⚠️⚠️

Hi! The buildbot x86 Gentoo Non-Debug with X 3.x has failed when building commit b1f648e.

What do you need to do:

1. Don't panic.
2. Check the buildbot page in the devguide if you don't know what the buildbots are or how they work.
3. Go to the page of the buildbot that failed (https://buildbot.python.org/all/#builders/58/builds/2801) and take a look at the build logs.
4. Check if the failure is related to this commit (b1f648e) or if it is a false positive.
5. If the failure is related to this commit, please, reflect that on the issue and make a new Pull Request with a fix.

You can take a look at the buildbot page here:

https://buildbot.python.org/all/#builders/58/builds/2801

Summary of the results of the build (if available):

== Tests result: ENV CHANGED ==

424 tests OK.

10 slowest tests:

• test_multiprocessing_spawn: 6 min 19 sec
• test_tokenize: 4 min 8 sec
• test_concurrent_futures: 4 min 6 sec
• test_asyncio: 3 min 24 sec
• test_unparse: 2 min 48 sec
• test_lib2to3: 2 min 25 sec
• test_multiprocessing_fork: 1 min 48 sec
• test_multiprocessing_forkserver: 1 min 40 sec
• test_gdb: 1 min 39 sec
• test_venv: 1 min 31 sec

1 test altered the execution environment:
test_import

11 tests skipped:
test_dbm_ndbm test_devpoll test_ioctl test_kqueue test_launcher
test_msilib test_startfile test_winconsoleio test_winreg
test_winsound test_zipfile64

Total duration: 40 min 57 sec

Click to see traceback logs

TracebackTests.test_unencodable_filename) ... ok TracebackTests.test_nonexistent_module) ... ok TracebackTests.test_broken_submodule) ... ok TracebackTests.test_broken_from) ... ok TracebackTests.test_exec_failure_nested) ... ok TracebackTests.test_import_bug) ... ok TracebackTests.test_nonexistent_module_nested) ... ok TracebackTests.test_exec_failure) ... ok Traceback (most recent call last): File "/buildbot/buildarea/cpython/3.x.ware-gentoo-x86.nondebug/build/Lib/threading.py", line 1036, in _bootstrap_innerself.run() File "/buildbot/buildarea/cpython/3.x.ware-gentoo-x86.nondebug/build/Lib/threading.py", line 973, in runself._target(*self._args, **self._kwargs) File "/buildbot/buildarea/cpython/3.x.ware-gentoo-x86.nondebug/build/Lib/test/test_import/__init__.py", line 471, in run sys.settrace(None) RuntimeError: Cannot install a trace function while another trace function is being installed k TracebackTests.test_broken_parent_from) ... ok TracebackTests.test_broken_parent) ... ok TracebackTests.test_syntax_error) ... ok 

[erlend-aasland]

The failure in test_concurrency seems unrelated to this PR.