gh-93678: Address stack exhaustion on WASI (GH-95296)#95296
Merged
+9 −4
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Commit 75c0c1b added function calls that increase stack consumption slightly. This pushed recursion tests over the call stack limit of wasmtime and broke three tests on wasm32-wasi. Skip two tests and lower recursion limit of the third test.
MemberAuthor
tiran commented Jul 26, 2022
Member
iritkatriel commented Jul 26, 2022
Are you sure you want to skip the tests? I’m hoping to get to the bottom of my change and reverse the impact. |
MemberAuthor
tiran commented Jul 26, 2022
Temporarily until you have developed a fix. The WASI buildbot is a stable tier 3 bot. The failing tests are showing up in unrelated PRs. |
iritkatriel approved these changes Jul 26, 2022
tiran changed the title 
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Commit 75c0c1b added function calls that increase stack consumption
slightly. This pushed recursion tests over the call stack limit of
wasmtime and broke three tests on wasm32-wasi.
Skip two tests and lower recursion limit of the third test.