Uh oh!
There was an error while loading. Please reload this page.
- Notifications
You must be signed in to change notification settings - Fork 34k
gh-95273: Move sqlite3 executemany examples from reference to tutorial#95351
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
gh-95273: Move sqlite3 executemany examples from reference to tutorial #95351
Uh oh!
There was an error while loading. Please reload this page.
Conversation
erlend-aasland commented Jul 27, 2022
My 2 cents: The executemany examples are way more complex than the average user needs. We should focus on the sqlite3 module; not on writing fancy iterators. The only thing that bothers me, is that we do not explicitly mention that the cursor can be used as an iterator. We could add a mention in the cursor class description. |
CAM-Gerlach left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
A couple minor comments, otherwise LGTM. Thanks @erlend-aasland !
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
Co-authored-by: CAM Gerlach <CAM.Gerlach@Gerlach.CAM>
Co-authored-by: CAM Gerlach <CAM.Gerlach@Gerlach.CAM>
erlend-aasland commented Jul 28, 2022 • edited
Loading Uh oh!
There was an error while loading. Please reload this page.
edited
Uh oh!
There was an error while loading. Please reload this page.
AlexWaygood commented Jul 28, 2022
I've got quite a lot on at the moment, so I'll leave this one in @CAM-Gerlach's very capable hands, if that's okay! |
erlend-aasland commented Jul 28, 2022
I wonder if it may make sense to keep a minimum example in the reference, though. The two previous examples ate more than a screenful. How about leaving something like this: |
CAM-Gerlach commented Jul 29, 2022 • edited
Loading Uh oh!
There was an error while loading. Please reload this page.
edited
Uh oh!
There was an error while loading. Please reload this page.
SGTM; concise examples can certainly be helpful to aiding understanding and this one certainly helps me understand the purpose of |
CAM-Gerlach left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, thanks @erlend-aasland 👍
Uh oh!
There was an error while loading. Please reload this page.
miss-islington commented Jul 29, 2022
Thanks @erlend-aasland for the PR 🌮🎉.. I'm working now to backport this PR to: 3.10. |
miss-islington commented Jul 29, 2022
Thanks @erlend-aasland for the PR 🌮🎉.. I'm working now to backport this PR to: 3.11. |
…utorial (pythonGH-95351) (cherry picked from commit f0bf795) Co-authored-by: Erlend Egeberg Aasland <erlend.aasland@innova.no>
bedevere-bot commented Jul 29, 2022
GH-95420 is a backport of this pull request to the 3.10 branch. |
…utorial (pythonGH-95351) (cherry picked from commit f0bf795) Co-authored-by: Erlend Egeberg Aasland <erlend.aasland@innova.no>
bedevere-bot commented Jul 29, 2022
GH-95421 is a backport of this pull request to the 3.11 branch. |
Uh oh!
There was an error while loading. Please reload this page.