Skip to content

gh-95271: Extract placeholders howto from sqlite3 tutorial#95522

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
erlend-aasland merged 8 commits into from
Aug 4, 2022
Merged

gh-95271: Extract placeholders howto from sqlite3 tutorial #95522

erlend-aasland merged 8 commits into from
Aug 4, 2022

Conversation

@erlend-aasland
Copy link
Contributor

@erlend-aaslanderlend-aasland commented Aug 1, 2022•
edited
Loading

@erlend-aaslanderlend-aasland added needs backport to 3.10 only security fixes needs backport to 3.11 only security fixes labels Aug 1, 2022
@erlend-aaslanderlend-aasland mentioned this pull request Aug 1, 2022
Closed
@erlend-aasland
Copy link
ContributorAuthor

erlend-aasland commented Aug 1, 2022

The placeholders howto can get an overhaul in a separate PR; for now, just move it.

CAM-Gerlach
CAM-Gerlach requested changes Aug 2, 2022
View reviewed changes
Copy link
Member

@CAM-GerlachCAM-Gerlach left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Given the stated scope of this PR I won't comment on anything but the move, but there is one pretty important thing missing—the section heading for the new How-To section :)

Otherwise, LGTM within the stated scope.

ezio-melotti
ezio-melotti reviewed Aug 2, 2022
View reviewed changes
CAM-Gerlach
CAM-Gerlach approved these changes Aug 3, 2022
View reviewed changes
Copy link
Member

@CAM-GerlachCAM-Gerlach left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM from me, thanks, aside from what @ezio-melotti pointed out

@erlend-aasland
Merge branch 'main' into sqlite-tutorial/extract-placeholders
9c87641
@erlend-aasland
Address review: mention injection attacks
bf717fe
@erlend-aasland
Improvements:
a0cdf61
- plural agreement, as CAM says - more brevity - add wikipedia link to SQL injection attacks
CAM-Gerlach
CAM-Gerlach approved these changes Aug 3, 2022
View reviewed changes
Copy link
Member

@CAM-GerlachCAM-Gerlach left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One minor comment, otherwise LGTM for now—thanks @erlend-aasland !

@CAM-Gerlach
Use literal question mark
1d840ca
Co-authored-by: CAM Gerlach <CAM.Gerlach@Gerlach.CAM>
@erlend-aasland
Copy link
ContributorAuthor

erlend-aasland commented Aug 3, 2022•
edited
Loading

I'll wait for Ezio's thumbs-up before landing, since he requested this change in the first place.

ezio-melotti
ezio-melotti reviewed Aug 3, 2022
View reviewed changes
@ezio-melotti
Consistency FTW
86d86c0
Co-authored-by: Ezio Melotti <ezio.melotti@gmail.com>
@erlend-aasland
Copy link
ContributorAuthor

erlend-aasland commented Aug 4, 2022

FYI, landing this tonight (CET).

@erlend-aasland
Copy link
ContributorAuthor

erlend-aasland commented Aug 4, 2022

Thanks for the reviews, both of you! Having more eyes helps 👀

@erlend-aaslanderlend-aasland merged commit b24e8b2 into python:mainAug 4, 2022
@miss-islington
Copy link
Contributor

miss-islington commented Aug 4, 2022

Thanks @erlend-aasland for the PR 🌮🎉.. I'm working now to backport this PR to: 3.10, 3.11.
🐍🍒⛏🤖

@erlend-aaslanderlend-aasland deleted the sqlite-tutorial/extract-placeholders branch August 4, 2022 20:41
@bedevere-bot
Copy link

bedevere-bot commented Aug 4, 2022

GH-95677 is a backport of this pull request to the 3.11 branch.

@bedevere-botbedevere-bot removed the needs backport to 3.11 only security fixes label Aug 4, 2022
erlend-aasland added a commit to erlend-aasland/cpython that referenced this pull request Aug 4, 2022
@erlend-aasland
[3.11]pythongh-95271: Extract placeholders howto from sqlite3 tutori…
9d3e42f
…al (pythonGH-95522) Co-authored-by: CAM Gerlach <CAM.Gerlach@Gerlach.CAM> Co-authored-by: Ezio Melotti <ezio.melotti@gmail.com> (cherry picked from commit b24e8b2) Co-authored-by: Erlend Egeberg Aasland <erlend.aasland@protonmail.com>
erlend-aasland added a commit to erlend-aasland/cpython that referenced this pull request Aug 4, 2022
@erlend-aasland
[3.10]pythongh-95271: Extract placeholders howto from sqlite3 tutori…
705f579
…al (pythonGH-95522) Co-authored-by: CAM Gerlach <CAM.Gerlach@Gerlach.CAM> Co-authored-by: Ezio Melotti <ezio.melotti@gmail.com> (cherry picked from commit b24e8b2) Co-authored-by: Erlend Egeberg Aasland <erlend.aasland@protonmail.com>
@bedevere-botbedevere-bot removed the needs backport to 3.10 only security fixes label Aug 4, 2022
@bedevere-bot
Copy link

bedevere-bot commented Aug 4, 2022

GH-95678 is a backport of this pull request to the 3.10 branch.

erlend-aasland added a commit that referenced this pull request Aug 4, 2022
@erlend-aasland
[3.10]gh-95271: Extract placeholders howto from sqlite3 tutorial (GH…
54ea127
…-95522) (#95678) Co-authored-by: CAM Gerlach <CAM.Gerlach@Gerlach.CAM> Co-authored-by: Ezio Melotti <ezio.melotti@gmail.com> (cherry picked from commit b24e8b2) Co-authored-by: Erlend Egeberg Aasland <erlend.aasland@protonmail.com>
erlend-aasland added a commit that referenced this pull request Aug 4, 2022
@erlend-aasland
[3.11]gh-95271: Extract placeholders howto from sqlite3 tutorial (GH…
4d37b42
…-95522) (#95677) Co-authored-by: CAM Gerlach <CAM.Gerlach@Gerlach.CAM> Co-authored-by: Ezio Melotti <ezio.melotti@gmail.com> (cherry picked from commit b24e8b2) Co-authored-by: Erlend Egeberg Aasland <erlend.aasland@protonmail.com>
iritkatriel pushed a commit to iritkatriel/cpython that referenced this pull request Aug 11, 2022
@erlend-aasland@CAM-Gerlach
@ezio-melotti@iritkatriel
pythongh-95271: Extract placeholders howto from sqlite3 tutorial (pyt…
96b7ac5
…hon#95522) Co-authored-by: CAM Gerlach <CAM.Gerlach@Gerlach.CAM> Co-authored-by: Ezio Melotti <ezio.melotti@gmail.com>
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@ezio-melottiezio-melottiezio-melotti left review comments

@CAM-GerlachCAM-GerlachCAM-Gerlach approved these changes

@berkerpeksagberkerpeksagAwaiting requested review from berkerpeksagberkerpeksag is a code owner

Assignees

No one assigned

Labels

docsDocumentation in the Doc dirskip news

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Improve the sqlite3 tutorial

5 participants

@erlend-aasland@miss-islington@bedevere-bot@CAM-Gerlach@ezio-melotti