Skip to content

gh-91207: Fix CSS bug with docs for Windows CHM help & add depr msg#95607

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
zooba merged 3 commits into from
Aug 3, 2022
Merged

gh-91207: Fix CSS bug with docs for Windows CHM help & add depr msg #95607

zooba merged 3 commits into from
Aug 3, 2022

Conversation

@CAM-Gerlach
Copy link
Member

@CAM-GerlachCAM-Gerlach commented Aug 3, 2022•
edited by bedevere-bot
Loading

Reported as #91207 and originally fixed just on 3.10 as #95556 ; forward-ported to 3.12 and 3.11 here, along with a deprecation message for the discontinued legacy CHM builds.

@CAM-GerlachCAM-Gerlachforce-pushed the forwardport-chm-html-fix branch from c110739 to 124e72dCompareAugust 3, 2022 18:51
@CAM-GerlachCAM-Gerlach added docs Documentation in the Doc dir OS-windows 3.11 only security fixes 3.12 only security fixes needs backport to 3.11 only security fixes labels Aug 3, 2022
@CAM-GerlachCAM-Gerlach requested a review from zoobaAugust 3, 2022 18:52
@CAM-GerlachCAM-Gerlach mentioned this pull request Aug 3, 2022
Closed
@zoobazooba merged commit ac3bf61 into python:mainAug 3, 2022
@miss-islington
Copy link
Contributor

miss-islington commented Aug 3, 2022

Thanks @CAM-Gerlach for the PR, and @zooba for merging it 🌮🎉.. I'm working now to backport this PR to: 3.11.
🐍🍒⛏🤖

@miss-islington
Copy link
Contributor

miss-islington commented Aug 3, 2022

Sorry @CAM-Gerlach and @zooba, I had trouble checking out the 3.11 backport branch.
Please backport using cherry_picker on command line.
cherry_picker ac3bf6155f8addc62f9a9c48f07eef8c3a6f71b2 3.11

@zoobazooba added needs backport to 3.11 only security fixes and removed needs backport to 3.11 only security fixes labels Aug 3, 2022
@miss-islington
Copy link
Contributor

miss-islington commented Aug 3, 2022

Thanks @CAM-Gerlach for the PR, and @zooba for merging it 🌮🎉.. I'm working now to backport this PR to: 3.11.
🐍🍒⛏🤖

@miss-islington
Copy link
Contributor

miss-islington commented Aug 3, 2022

Sorry @CAM-Gerlach and @zooba, I had trouble checking out the 3.11 backport branch.
Please backport using cherry_picker on command line.
cherry_picker ac3bf6155f8addc62f9a9c48f07eef8c3a6f71b2 3.11

@zoobazooba added needs backport to 3.11 only security fixes and removed needs backport to 3.11 only security fixes labels Aug 3, 2022
@miss-islington
Copy link
Contributor

miss-islington commented Aug 3, 2022

Thanks @CAM-Gerlach for the PR, and @zooba for merging it 🌮🎉.. I'm working now to backport this PR to: 3.11.
🐍🍒⛏🤖

@bedevere-botbedevere-bot removed the needs backport to 3.11 only security fixes label Aug 3, 2022
@bedevere-bot
Copy link

bedevere-bot commented Aug 3, 2022

GH-95617 is a backport of this pull request to the 3.11 branch.

miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Aug 3, 2022
@CAM-Gerlach@miss-islington
pythongh-91207: Fix CSS bug in Windows CHM help file and add deprecat…
ca0b554
…ion message (pythonGH-95607) (cherry picked from commit ac3bf61) Co-authored-by: CAM Gerlach <CAM.Gerlach@Gerlach.CAM>
miss-islington added a commit that referenced this pull request Aug 3, 2022
@miss-islington@CAM-Gerlach
gh-91207: Fix CSS bug in Windows CHM help file and add deprecation me…
a591c47
…ssage (GH-95607) (cherry picked from commit ac3bf61) Co-authored-by: CAM Gerlach <CAM.Gerlach@Gerlach.CAM>
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@zoobazoobazooba approved these changes

Assignees

@zoobazooba

Labels

3.11only security fixes3.12only security fixesdocsDocumentation in the Doc dirOS-windows

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@CAM-Gerlach@miss-islington@bedevere-bot@zooba