gh-93274: Expose receiving vectorcall in the Limited API#95717
Merged
Uh oh!
There was an error while loading. Please reload this page.
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Contributor
wjakob commented Aug 5, 2022
This looks great. Leaving |
erlend-aasland approved these changes Aug 5, 2022
Contributor
erlend-aasland left a comment
erlend-aasland left a comment There was a problem hiding this comment.
Looks good, with minor nits!
BTW, in Modules/_testcapi/vectorcall_limited.c, everything but _PyTestCapi_Init_VectorcallLimited method can be made static. Not that it matters much for a test module, though.
Objects/call.c Outdated
| } | ||
| // Export for the stable ABI | ||
| #undef PyVectorcall_NARGS(n) |
Contributor
There was a problem hiding this comment.
Suggested change
| #undef PyVectorcall_NARGS(n) | |
| #undef PyVectorcall_NARGS |
Uh oh!
There was an error while loading. Please reload this page.
bedevere-bot commented Aug 8, 2022
|
encukou added a commit to encukou/cpython that referenced this pull request Aug 8, 2022
MemberAuthor
encukou commented Aug 8, 2022
If anyone needs the TraceRefs buildbot green, please merge the revert. I'm working on a fix, so maybe a revert won't be necessary. |
Member
vstinner commented Aug 8, 2022
https://buildbot.python.org/all/#builders/484/builds/1920 failed to build:
IMO it's ok if it's broken for a few days, but it would be nice to fix it before next Python (3.12) release. |
MemberAuthor
encukou commented Aug 8, 2022
This'll hopefully fix it: #95796 |
iritkatriel pushed a commit to iritkatriel/cpython that referenced this pull request Aug 11, 2022
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.