Skip to content

gh-90928: Improve static initialization of keywords tuple in AC#95907

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
erlend-aasland merged 6 commits into from
Aug 13, 2022
Merged

gh-90928: Improve static initialization of keywords tuple in AC #95907

erlend-aasland merged 6 commits into from
Aug 13, 2022

Conversation

@erlend-aasland
Copy link
Contributor

@erlend-aaslanderlend-aasland commented Aug 11, 2022•
edited
Loading

Calculate num_keywords during template generation instead of leaving it to the preprocessor. This makes for much smaller and easier to read (FWIW) AC output.

See discussion in #95860 (comment)

@erlend-aaslanderlend-aasland mentioned this pull request Aug 11, 2022
Merged
@erlend-aaslanderlend-aasland marked this pull request as ready for review August 11, 2022 22:51
ericsnowcurrently
ericsnowcurrently requested changes Aug 11, 2022
View reviewed changes
Copy link
Member

@ericsnowcurrentlyericsnowcurrently left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for working on this! Mostly LGTM.

Also, can you drop "num_keywords" from template_dict now?

@bedevere-bot
Copy link

bedevere-bot commented Aug 11, 2022

When you're done making the requested changes, leave the comment: I have made the requested changes; please review again.

@erlend-aasland
Copy link
ContributorAuthor

erlend-aasland commented Aug 11, 2022

Also, can you drop "num_keywords" from template_dict now?

It is already dropped :)

@erlend-aasland
Copy link
ContributorAuthor

erlend-aasland commented Aug 11, 2022

I have made the requested changes; please review again.

@bedevere-bot
Copy link

bedevere-bot commented Aug 11, 2022

Thanks for making the requested changes!

@ericsnowcurrently: please review the changes made to this pull request.

@kumaraditya303kumaraditya303 self-requested a review August 12, 2022 17:09
ericsnowcurrently
ericsnowcurrently approved these changes Aug 12, 2022
View reviewed changes
Copy link
Member

@ericsnowcurrentlyericsnowcurrently left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

I'll leave it up to you about the two comments I left.

@ericsnowcurrently
Update Tools/clinic/clinic.py
f1d533c
Co-authored-by: Eric Snow <ericsnowcurrently@gmail.com>
erlend-aasland
erlend-aasland commented Aug 12, 2022
View reviewed changes
@erlend-aasland
Copy link
ContributorAuthor

erlend-aasland commented Aug 12, 2022

Thanks for reviewing; highly appreciated. I'll make a quick adjustment before landing.

@erlend-aasland
Address last round of reviews
8915c05
- inline len(keywords) - use NUM_KEYWORDS constant for improved readability in generated code
@erlend-aasland
Copy link
ContributorAuthor

erlend-aasland commented Aug 12, 2022

I'm done with the last round of adjustments. I ended up adding both of your last suggestions. Thanks again.

@erlend-aasland
Copy link
ContributorAuthor

erlend-aasland commented Aug 12, 2022

FYI, I'll wait with merging until Kumar has finished his review.

kumaraditya303
kumaraditya303 approved these changes Aug 13, 2022
View reviewed changes
Copy link
Contributor

@kumaraditya303kumaraditya303 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks!

@erlend-aasland
Copy link
ContributorAuthor

erlend-aasland commented Aug 13, 2022

Thanks for the reviews!

@erlend-aaslanderlend-aasland merged commit f07adf8 into python:mainAug 13, 2022
@erlend-aaslanderlend-aasland deleted the improve-gh-95860 branch August 13, 2022 10:10
@erlend-aaslanderlend-aasland mentioned this pull request Aug 16, 2023
Merged
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@ericsnowcurrentlyericsnowcurrentlyericsnowcurrently approved these changes

@kumaraditya303kumaraditya303kumaraditya303 approved these changes

Assignees

No one assigned

Labels

skip news

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@erlend-aasland@bedevere-bot@ericsnowcurrently@kumaraditya303