Uh oh!
There was an error while loading. Please reload this page.
- Notifications
You must be signed in to change notification settings - Fork 34k
gh-96005: Handle WASI ENOTCAPABLE in getpath (GH-96006)#96006
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Uh oh!
There was an error while loading. Please reload this page.
Conversation
tiran commented Aug 15, 2022 • edited by bedevere-bot
Loading Uh oh!
There was an error while loading. Please reload this page.
edited by bedevere-bot
Uh oh!
There was an error while loading. Please reload this page.
- On WASI `ENOTCAPABLE` is now mapped to `PermissionError`. - The `errno` modules exposes the new error number. - `getpath.py` now ignores `PermissionError` when it cannot open landmark files `pybuilddir.txt` and `pyenv.cfg`.
zooba left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
tiran commented Aug 16, 2022
@pablogsal RM, is this an acceptable change for 3.11.0, should I delay it for 3.11.1, or only apply it to 3.12? |
pablogsal commented Aug 16, 2022 • edited
Loading Uh oh!
There was an error while loading. Please reload this page.
edited
Uh oh!
There was an error while loading. Please reload this page.
This is likely too big for 3.11.0 :( are you ok delaying this to 3.11.1? |
tiran commented Aug 16, 2022
Sure, no problem! I'll update the docs. |
miss-islington commented Aug 16, 2022
Thanks @tiran for the PR 🌮🎉.. I'm working now to backport this PR to: 3.11. |
- On WASI `ENOTCAPABLE` is now mapped to `PermissionError`. - The `errno` modules exposes the new error number. - `getpath.py` now ignores `PermissionError` when it cannot open landmark files `pybuilddir.txt` and `pyenv.cfg`. (cherry picked from commit 48174fa) Co-authored-by: Christian Heimes <[email protected]>
bedevere-bot commented Aug 16, 2022
GH-96032 is a backport of this pull request to the 3.11 branch. |
bedevere-bot commented Aug 16, 2022
|
pablogsal commented Aug 16, 2022
@tiran That looks like a genuine failure |
tiran commented Aug 16, 2022
Will investigate later |
) (GH-96038) - On WASI `ENOTCAPABLE` is now mapped to `PermissionError`. - The `errno` modules exposes the new error number. - `getpath.py` now ignores `PermissionError` when it cannot open landmark files `pybuilddir.txt` and `pyenv.cfg`.
ENOTCAPABLEis now mapped toPermissionError.errnomodules exposes the new error number.getpath.pynow ignoresPermissionErrorwhen it cannot open landmarkfiles
pybuilddir.txtandpyenv.cfg.