gh-96017: Fix some compiler warnings (GH-96018)#96018
Merged
Uh oh!
There was an error while loading. Please reload this page.
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
- "comparison of integers of different signs" in typeobject.c - only define static_builtin_index_is_set in DEBUG builds - unset NDEBUG before including assert.h - only define recreate_gil with ifdef HAVE_FORK
tiran added needs backport to 3.11 
encukou reviewed Aug 16, 2022
Uh oh!
There was an error while loading. Please reload this page.
tiran changed the title 
Contributor
miss-islington commented Aug 19, 2022
Thanks @tiran for the PR 🌮🎉.. I'm working now to backport this PR to: 3.11. |
Contributor
miss-islington commented Aug 19, 2022
Sorry, @tiran, I could not cleanly backport this to |
tiran added a commit to tiran/cpython that referenced this pull request Aug 19, 2022
- "comparison of integers of different signs" in typeobject.c - only define static_builtin_index_is_set in DEBUG builds - only define recreate_gil with ifdef HAVE_FORK. (cherry picked from commit d9c1b74) Co-authored-by: Christian Heimes <[email protected]>
bedevere-bot commented Aug 19, 2022
GH-96106 is a backport of this pull request to the 3.11 branch. |
ambv pushed a commit that referenced this pull request Oct 5, 2022
- only define recreate_gil with ifdef HAVE_FORK. (cherry picked from commit d9c1b74) Co-authored-by: Christian Heimes <[email protected]>
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.