[3.11] GH-95736: fix IsolatedAsyncioTestCase to initialize Runner before calling setup functions (GH-95898)#96027
Uh oh!
There was an error while loading. Please reload this page.
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
…re calling setup functions (pythonGH-95898) (cherry picked from commit 9d51599) Co-authored-by: Kumar Aditya <[email protected]>
ContributorAuthor
miss-islington commented Aug 16, 2022
Status check is done, and it's a success ✅ . |
2 similar comments
ContributorAuthor
miss-islington commented Aug 16, 2022
Status check is done, and it's a success ✅ . |
ContributorAuthor
miss-islington commented Aug 16, 2022
Status check is done, and it's a success ✅ . |
Member
gvanrossum commented Aug 16, 2022
@pablogsal This is the last one I sponsor, I promise. |
ContributorAuthor
miss-islington commented Aug 16, 2022
Status check is done, and it's a success ✅ . |
Member
tiran commented Aug 16, 2022
The changeset breaks tests on Emscripten. |
Contributor
kumaraditya303 commented Aug 17, 2022
Superseded by #96042 |
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
(cherry picked from commit 9d51599)
Co-authored-by: Kumar Aditya [email protected]
IsolatedAsyncioTestCasedoes not callasyncio.set_event_loopbeforesetUpanymore,asyncio.Runner+PidFdChildWatcherleaves zombie processes #95736