[3.11] gh-94823: Improve coverage in tokenizer.c:valid_utf8 (GH-94856)#96029
Uh oh!
There was an error while loading. Please reload this page.
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
…94856) When loading a source file from disk, there is a separate UTF-8 validator distinct from the one in `unicode_decode_utf8`. This exercises that code path with the same set of invalid inputs as we use for testing the "other" UTF-8 decoder. (cherry picked from commit f215d7c) Co-authored-by: Michael Droettboom <[email protected]>
ContributorAuthor
miss-islington commented Aug 16, 2022
Status check is done, and it's a success ✅ . |
pablogsal approved these changes Aug 16, 2022
ContributorAuthor
miss-islington commented Aug 16, 2022
Sorry, I can't merge this PR. Reason: |
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When loading a source file from disk, there is a separate UTF-8 validator
distinct from the one in
unicode_decode_utf8. This exercises that code pathwith the same set of invalid inputs as we use for testing the "other" UTF-8
decoder.
(cherry picked from commit f215d7c)
Co-authored-by: Michael Droettboom [email protected]