Skip to content

gh-95913: make the new internal classes pdb.ModuleTarget/ScriptTarget private#96053

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
iritkatriel merged 2 commits into from
Aug 18, 2022
Merged

gh-95913: make the new internal classes pdb.ModuleTarget/ScriptTarget private #96053

iritkatriel merged 2 commits into from
Aug 18, 2022

Conversation

@iritkatriel
Copy link
Member

@iritkatrieliritkatriel commented Aug 17, 2022•
edited by bedevere-bot
Loading

jaraco
jaraco approved these changes Aug 18, 2022
View reviewed changes
Copy link
Member

@jaracojaraco left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for doing this!

@iritkatrieliritkatriel merged commit 1a720c6 into python:mainAug 18, 2022
@miss-islington
Copy link
Contributor

miss-islington commented Aug 18, 2022

Thanks @iritkatriel for the PR 🌮🎉.. I'm working now to backport this PR to: 3.11.
🐍🍒⛏🤖

@bedevere-bot
Copy link

bedevere-bot commented Aug 18, 2022

GH-96063 is a backport of this pull request to the 3.11 branch.

@bedevere-botbedevere-bot removed the needs backport to 3.11 only security fixes label Aug 18, 2022
miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Aug 18, 2022
@iritkatriel@miss-islington
pythongh-95913: make the new internal classes pdb.ModuleTarget/Script…
117c7c6
…Target private (pythonGH-96053) (cherry picked from commit 1a720c6) Co-authored-by: Irit Katriel <1055913+iritkatriel@users.noreply.github.com>
pablogsal pushed a commit that referenced this pull request Aug 18, 2022
@miss-islington@iritkatriel
[3.11]gh-95913: make the new internal classes pdb.ModuleTarget/Scrip…
1b9b485
…tTarget private (GH-96053) (#96063) Co-authored-by: Irit Katriel <1055913+iritkatriel@users.noreply.github.com>
tiran pushed a commit to tiran/cpython that referenced this pull request Aug 19, 2022
@iritkatriel@tiran
pythongh-95913: make the new internal classes pdb.ModuleTarget/Script…
eae213f
…Target private (pythonGH-96053)
@iritkatrieliritkatriel deleted the pdb_private branch September 29, 2022 17:03
@CAM-GerlachCAM-Gerlach mentioned this pull request Oct 2, 2022
Closed
33 tasks
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@jaracojaracojaraco approved these changes

@pablogsalpablogsalAwaiting requested review from pablogsal

Assignees

No one assigned

Labels

skip news

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@iritkatriel@miss-islington@bedevere-bot@jaraco