[3.10] gh-96021: Explicitly close the IsolatedAsyncioTestCase runner in tests (GH-96135)#96235
Uh oh!
There was an error while loading. Please reload this page.
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
ContributorAuthor
miss-islington commented Aug 24, 2022
@serhiy-storchaka: Status check is done, and it's a failure ❌ . |
ContributorAuthor
miss-islington commented Aug 24, 2022
@serhiy-storchaka: Status check is done, and it's a failure ❌ . |
ContributorAuthor
miss-islington commented Aug 24, 2022
Status check is done, and it's a success ✅ . |
ContributorAuthor
miss-islington commented Aug 24, 2022
@serhiy-storchaka: Status check is done, and it's a success ❌ . |
serhiy-storchaka approved these changes Aug 25, 2022
… in tests (pythonGH-96135) Tests for IsolatedAsyncioTestCase.debug() rely on the runner be closed in __del__. It makes tests depending on the GC an unreliable on other implementations. It is better to tear down the loop explicitly even if currently there is no a public API for this. (cherry picked from commit 4de06e3) Co-authored-by: Serhiy Storchaka <[email protected]>
serhiy-storchakaforce-pushed the backport-4de06e3-3.10 branch from 7f2198a to bc069b0Compare
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Tests for IsolatedAsyncioTestCase.debug() rely on the runner be closed
in del. It makes tests depending on the GC an unreliable on other
implementations. It is better to close the runner explicitly even if
currently there is no a public API for this.
(cherry picked from commit 4de06e3)
Co-authored-by: Serhiy Storchaka [email protected]
__del__could be dangerous #96021