gh-94808: Cover PyObject_PyBytes case with custom __bytes__ method#96610
Uh oh!
There was an error while loading. Please reload this page.
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
kumaraditya303 approved these changes Sep 6, 2022
kumaraditya303 added needs backport to 3.10 Lib/test/test_long.py Outdated
| self.assertEqual(int.from_bytes(ValidBytes()), 1) | ||
| self.assertRaises(TypeError, int.from_bytes, InvalidBytes) | ||
| self.assertRaises(TypeError, int.from_bytes, MissingBytes) | ||
| self.assertRaises(TypeError, int.from_bytes, RaisingBytes) |
Member
There was a problem hiding this comment.
This shouldn't raise TypeError:
>>> class RaisingBytes: ... def __bytes__(self): ... 1 / 0 ... >>> int.from_bytes(RaisingBytes()) Traceback (most recent call last): File "<stdin>", line 1, in <module> File "<stdin>", line 3, in __bytes__ ZeroDivisionError: division by zero And yet CI is green. Am I missing something? I'm compiling your PR locally now to see what's going on.
Member
There was a problem hiding this comment.
Ah it's because you don't instantiate the class.
Contributor
There was a problem hiding this comment.
Oh, Good catch! Even I missed this.
Uh oh!
There was an error while loading. Please reload this page.
Co-authored-by: Jelle Zijlstra <jelle.zijlstra@gmail.com>
JelleZijlstra approved these changes Oct 6, 2022
Contributor
miss-islington commented Oct 6, 2022
Thanks @sobolevn for the PR, and @JelleZijlstra for merging it 🌮🎉.. I'm working now to backport this PR to: 3.10, 3.11. |
bedevere-bot commented Oct 6, 2022
GH-97960 is a backport of this pull request to the 3.11 branch. |
Contributor
miss-islington commented Oct 6, 2022
Sorry, @sobolevn and @JelleZijlstra, I could not cleanly backport this to |
miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Oct 6, 2022
… method (pythonGH-96610) Co-authored-by: Jelle Zijlstra <jelle.zijlstra@gmail.com> (cherry picked from commit e39ae6b) Co-authored-by: Nikita Sobolev <mail@sobolevn.me>
Member
JelleZijlstra commented Oct 6, 2022
@sobolevn do you want to do a manual 3.10 backport? |
MemberAuthor
sobolevn commented Oct 6, 2022
Yes, will do! |
Member
JelleZijlstra commented Oct 6, 2022
Thanks! |
carljm added a commit to carljm/cpython that referenced this pull request Oct 6, 2022
* main: pythonGH-88050: fix race in closing subprocess pipe in asyncio (python#97951) pythongh-93738: Disallow pre-v3 syntax in the C domain (python#97962) pythongh-95986: Fix the example using match keyword (python#95989) pythongh-97897: Prevent os.mkfifo and os.mknod segfaults with macOS 13 SDK (pythonGH-97944) pythongh-94808: Cover `PyUnicode_Count` in CAPI (python#96929) pythongh-94808: Cover `PyObject_PyBytes` case with custom `__bytes__` method (python#96610) pythongh-95691: Doc BufferedWriter and BufferedReader (python#95703) pythonGH-88968: Add notes about socket ownership transfers (python#97936) pythongh-96865: [Enum] fix Flag to use CONFORM boundary (pythonGH-97528)
carljm added a commit to carljm/cpython that referenced this pull request Oct 8, 2022
* main: (53 commits) pythongh-94808: Coverage: Test that maximum indentation level is handled (python#95926) pythonGH-88050: fix race in closing subprocess pipe in asyncio (python#97951) pythongh-93738: Disallow pre-v3 syntax in the C domain (python#97962) pythongh-95986: Fix the example using match keyword (python#95989) pythongh-97897: Prevent os.mkfifo and os.mknod segfaults with macOS 13 SDK (pythonGH-97944) pythongh-94808: Cover `PyUnicode_Count` in CAPI (python#96929) pythongh-94808: Cover `PyObject_PyBytes` case with custom `__bytes__` method (python#96610) pythongh-95691: Doc BufferedWriter and BufferedReader (python#95703) pythonGH-88968: Add notes about socket ownership transfers (python#97936) pythongh-96865: [Enum] fix Flag to use CONFORM boundary (pythonGH-97528) pythongh-65961: Raise `DeprecationWarning` when `__package__` differs from `__spec__.parent` (python#97879) docs(typing): add "see PEP 675" to LiteralString (python#97926) pythongh-97850: Remove all known instances of module_repr() (python#97876) I changed my surname early this year (python#96671) pythongh-93738: Documentation C syntax (:c:type:<C type> -> :c:expr:<C type>) (python#97768) pythongh-91539: improve performance of get_proxies_environment (python#91566) build(deps): bump actions/stale from 5 to 6 (python#97701) pythonGH-95172 Make the same version `versionadded` oneline (python#95172) pythongh-88050: Fix asyncio subprocess to kill process cleanly when process is blocked (python#32073) pythongh-93738: Documentation C syntax (Function glob patterns -> literal markup) (python#97774) ...
bedevere-bot commented Oct 9, 2022
GH-98121 is a backport of this pull request to the 3.10 branch. |
sobolevn added a commit to sobolevn/cpython that referenced this pull request Oct 9, 2022
…ytes__` method (pythonGH-96610) Co-authored-by: Jelle Zijlstra <jelle.zijlstra@gmail.com>. (cherry picked from commit e39ae6b) Co-authored-by: Nikita Sobolev <mail@sobolevn.me>
sobolevn added a commit to sobolevn/cpython that referenced this pull request Oct 9, 2022
…ytes__` method (pythonGH-96610) Co-authored-by: Jelle Zijlstra <jelle.zijlstra@gmail.com>. (cherry picked from commit e39ae6b) Co-authored-by: Nikita Sobolev <mail@sobolevn.me>
mpage pushed a commit to mpage/cpython that referenced this pull request Oct 11, 2022
… method (python#96610) Co-authored-by: Jelle Zijlstra <jelle.zijlstra@gmail.com>
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
There were two options:
_testcapimodule.cfunction to testPyObject_PyBytesdirectly. But, there's alreadypyobject_bytes_from_nullwhich only coversNULLcase. So, it is somewhat coveredPyObject_Bytes, likeint_from_bytes_impl. In this case we not only test C-API itself, but also do something useful for the end implementation (in this caseint.from_bytes)So, I went with
2.Probably it is still possible to add a new
_testcapimodule.cfunction in the next PR.