Skip to content

Conversation

@hawkinsw
Copy link
Contributor

Fix capitalization of Unix in multiprocessing documentation

@bedevere-botbedevere-bot added awaiting review docs Documentation in the Doc dir skip news labels Sep 18, 2022
Copy link
Contributor

@kumiDakumiDa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I was able to verify this change that corrects the deviation from the convention of addressing Unix in the documentation.
The change lgtm.

@hawkinsw
Copy link
ContributorAuthor

I was able to verify this change that corrects the deviation from the convention of addressing Unix in the documentation. The change lgtm.

Thank you @rahul-kumi!!

@JelleZijlstra
Copy link
Member

Thanks! Would you mind also changing these:

library/os.path.rst:Unlike a unix shell, Python does not do any *automatic* path expansions. library/test.rst: Bind a unix socket, raising :exc:`unittest.SkipTest` if 

And probably also these:

library/email.compat32-message.rst: required by the unix mbox format. For more flexibility, instantiate a library/email.compat32-message.rst: required by the unix mbox format. For more flexibility, instantiate a library/email.generator.rst: *mangle_from_* is intended for use when messages are stored in unix mbox library/email.generator.rst: *mangle_from_* is intended for use when messages are stored in unix mbox 

Change 'unix' to 'Unix' throughout documentation.
@hawkinsw
Copy link
ContributorAuthor

Thanks! Would you mind also changing these:

library/os.path.rst:Unlike a unix shell, Python does not do any *automatic* path expansions. library/test.rst: Bind a unix socket, raising :exc:`unittest.SkipTest` if 

And probably also these:

library/email.compat32-message.rst: required by the unix mbox format. For more flexibility, instantiate a library/email.compat32-message.rst: required by the unix mbox format. For more flexibility, instantiate a library/email.generator.rst: *mangle_from_* is intended for use when messages are stored in unix mbox library/email.generator.rst: *mangle_from_* is intended for use when messages are stored in unix mbox 

All updated! I have changed the title of the commit to better reflect that the change is a little wider than initially suggested. I also rebased against master to make it smoother! I hope that it helps! Thanks for the review!

Will

@miss-islington
Copy link
Contributor

Thanks @hawkinsw for the PR, and @JelleZijlstra for merging it 🌮🎉.. I'm working now to backport this PR to: 3.10, 3.11.
🐍🍒⛏🤖

@bedevere-bot
Copy link

GH-97711 is a backport of this pull request to the 3.11 branch.

@bedevere-botbedevere-bot removed the needs backport to 3.11 only security fixes label Oct 1, 2022
@bedevere-bot
Copy link

GH-97712 is a backport of this pull request to the 3.10 branch.

@bedevere-botbedevere-bot removed the needs backport to 3.10 only security fixes label Oct 1, 2022
miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Oct 1, 2022
(cherry picked from commit bd7d0e8) Co-authored-by: Will Hawkins <8715530+hawkinsw@users.noreply.github.com>
miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Oct 1, 2022
(cherry picked from commit bd7d0e8) Co-authored-by: Will Hawkins <8715530+hawkinsw@users.noreply.github.com>
miss-islington added a commit that referenced this pull request Oct 1, 2022
(cherry picked from commit bd7d0e8) Co-authored-by: Will Hawkins <8715530+hawkinsw@users.noreply.github.com>
miss-islington added a commit that referenced this pull request Oct 1, 2022
(cherry picked from commit bd7d0e8) Co-authored-by: Will Hawkins <8715530+hawkinsw@users.noreply.github.com>
serhiy-storchaka pushed a commit to serhiy-storchaka/cpython that referenced this pull request Oct 2, 2022
pablogsal pushed a commit that referenced this pull request Oct 22, 2022
(cherry picked from commit bd7d0e8) Co-authored-by: Will Hawkins <8715530+hawkinsw@users.noreply.github.com>
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

docsDocumentation in the Doc dirskip issueskip news

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants

@hawkinsw@JelleZijlstra@miss-islington@bedevere-bot@kumiDa@kumaraditya303