[3.9] gh-96848: Fix -X int_max_str_digits option parsing (GH-96988)#97574
Uh oh!
There was an error while loading. Please reload this page.
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
) Fix command line parsing: reject "-X int_max_str_digits" option with no value (invalid) when the PYTHONINTMAXSTRDIGITS environment variable is set to a valid limit. (cherry picked from commit 4135166) Co-authored-by: Victor Stinner <vstinner@python.org>
ContributorAuthor
miss-islington commented Sep 26, 2022
@vstinner: Status check is done, and it's a failure or timed out ❌. |
Contributor
ambv commented Oct 4, 2022
Test failing on Windows, looks legitimate: |
ContributorAuthor
miss-islington commented Oct 4, 2022
Status check is done, and it's a success ✅. |
ContributorAuthor
miss-islington commented Oct 4, 2022
Sorry, I can't merge this PR. Reason: |
Contributor
ambv commented Oct 4, 2022
...and it passed 🤔 |
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix command line parsing: reject "-X int_max_str_digits" option with
no value (invalid) when the PYTHONINTMAXSTRDIGITS environment
variable is set to a valid limit.
(cherry picked from commit 4135166)
Co-authored-by: Victor Stinner vstinner@python.org