GH-97592: Fix crash in C remove_done_callback due to evil code#97660
Uh oh!
There was an error while loading. Please reload this page.
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
gvanrossumforce-pushed the fix-fut-callbacks branch from 10daef4 to d407a0bCompare
gvanrossumforce-pushed the fix-fut-callbacks branch from 2ee888c to 00b9536Compare
MemberAuthor
gvanrossum commented Sep 29, 2022
@xiaxinmeng Feel free to add your review. |
JelleZijlstra approved these changes Sep 30, 2022
Misc/NEWS.d/next/Library/2022-09-29-23-22-24.gh-issue-97592.tpJg_J.rst Outdated Show resolvedHide resolved
Uh oh!
There was an error while loading. Please reload this page.
kumaraditya303 added topic-asyncio needs backport to 3.10 
CharlieZhao95 suggested changes Sep 30, 2022
Comment on lines +844 to +848
| classevil: | ||
| def__eq__(self, other): | ||
| fut.remove_done_callback(other) | ||
| fut.remove_done_callback(evil()) |
Contributor
There was a problem hiding this comment.
Class names should normally use the CapWords convention.
Suggested change
| classevil: | |
| def__eq__(self, other): | |
| fut.remove_done_callback(other) | |
| fut.remove_done_callback(evil()) | |
| classEvil: | |
| def__eq__(self, other): | |
| fut.remove_done_callback(other) | |
| fut.remove_done_callback(Evil()) |
| def__eq__(self, other): | ||
| fut.remove_done_callback(other) | ||
| fut.remove_done_callback(evil()) |
Contributor
There was a problem hiding this comment.
All callbacks added by fut.add_done_callback() will be cleared when calling fut.remove_done_callback(Evil()), but the return value will be the number of callbacks added last.
I'm not sure if we need to improve the return value of remove done callback further, the current changes are good enough to fix the crash. :)
Co-authored-by: Kumar Aditya <59607654+kumaraditya303@users.noreply.github.com>
Contributor
miss-islington commented Sep 30, 2022
Thanks @gvanrossum for the PR 🌮🎉.. I'm working now to backport this PR to: 3.10, 3.11. |
bedevere-bot commented Sep 30, 2022
GH-97692 is a backport of this pull request to the 3.11 branch. |
miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Sep 30, 2022
…ythonGH-97660) Evil code could cause fut_callbacks to be cleared when PyObject_RichCompareBool is called. (cherry picked from commit 63780f4) Co-authored-by: Guido van Rossum <guido@python.org>
bedevere-bot commented Sep 30, 2022
GH-97693 is a backport of this pull request to the 3.10 branch. |
miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Sep 30, 2022
…ythonGH-97660) Evil code could cause fut_callbacks to be cleared when PyObject_RichCompareBool is called. (cherry picked from commit 63780f4) Co-authored-by: Guido van Rossum <guido@python.org>
miss-islington added a commit that referenced this pull request Sep 30, 2022
) Evil code could cause fut_callbacks to be cleared when PyObject_RichCompareBool is called. (cherry picked from commit 63780f4) Co-authored-by: Guido van Rossum <guido@python.org>
miss-islington added a commit that referenced this pull request Sep 30, 2022
) Evil code could cause fut_callbacks to be cleared when PyObject_RichCompareBool is called. (cherry picked from commit 63780f4) Co-authored-by: Guido van Rossum <guido@python.org>
serhiy-storchaka pushed a commit to serhiy-storchaka/cpython that referenced this pull request Oct 2, 2022
…ython#97660) Evil code could cause fut_callbacks to be cleared when PyObject_RichCompareBool is called.
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.