Skip to content

Conversation

@vstinner
Copy link
Member

@vstinnervstinner commented Sep 30, 2022

Remove outdated example scripts. Copy them from Python 3.11 if you still need them.

Removed scripts:

  • byext.py
  • byteyears.py
  • cleanfuture.py
  • copytime.py
  • crlf.py
  • db2pickle.py
  • dutree.doc
  • dutree.py
  • find-uname.py
  • find_recursionlimit.py
  • finddiv.py
  • findlinksto.py
  • findnocoding.py
  • fixcid.py
  • fixdiv.py
  • fixheader.py
  • fixnotice.py
  • fixps.py
  • get-remote-certificate.py
  • google.py
  • highlight.py
  • ifdef.py
  • import_diagnostics.py
  • lfcr.py
  • linktree.py
  • lll.py
  • mailerdaemon.py
  • make_ctype.py
  • mkreal.py
  • objgraph.py
  • pdeps.py
  • pickle2db.py
  • pindent.py
  • pysource.py
  • reindent-rst.py
  • rgrep.py
  • suff.py
  • texi2html.py
  • which.py

Changes:

  • Remove test_fixcid, test_lll, test_pdeps and test_pindent of test.test_tools.
  • Remove get-remote-certificate.py changelog entry, since the script was removed.
  • FYI there is a copy of crlf.py in Lib/test/test_lib2to3/data/.

@vstinner
Copy link
MemberAuthor

Here is a first PR to remove scripts which look outdated to me. The remaining ones might be useful or are referenced in other parts of Python, so I prefer to write separated PRs for the other scripts that I plan to remove.

Since my first version, I restored md5sum.py and parse_html5_entities.py removed by mistake. I alsot restored untabify.py since it's used by patchcheck.py.

Note: first I created PR #97674 on the branch name "main" which is not convenient, so I closed it and created this PR instead.

@ericsnowcurrently
Copy link
Member

ericsnowcurrently commented Sep 30, 2022

It would be good to preserve at least some of these before this PR (or other PRs) get merged. See my post at https://discuss.python.org/t/remove-outdated-tools-scripts-scripts/19571/22.

I'm okay with simply finding the scripts on the 3.11 branch.

Copy link
Member

@gvanrossumgvanrossum left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I might preserve these too (in the same repo) but not right now. Go ahead with the removal though.

@vstinner
Copy link
MemberAuthor

I might preserve these too (in the same repo) but not right now. Go ahead with the removal though.

Once most scripts will be removed and a copy of these scripts will be created, we can document the removal in What's New In Python 3.12 with a link to this copy.

@warsaw
Copy link
Member

mailerdaemon.py can probably be replaced (possibly with some wrapper code) with flufl.bounce.

Copy link
Member

@gvanrossumgvanrossum left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sure. I expect that we may be removing one or two scripts that are still depended on by some platform or workflow, but that's okay -- we'll just restore those when we get complaints.

@gvanrossum
Copy link
Member

And yes, these are now also in my https://github.com/gvanrossum/old-demos repo.

Remove outdated example scripts of the Tools/scripts/ directory. A copy can be found in the old-demos project: https://github.com/gvanrossum/old-demos Removed scripts (39): * byext.py * byteyears.py * cleanfuture.py * copytime.py * crlf.py * db2pickle.py * dutree.doc * dutree.py * find-uname.py * find_recursionlimit.py * finddiv.py * findlinksto.py * findnocoding.py * fixcid.py * fixdiv.py * fixheader.py * fixnotice.py * fixps.py * get-remote-certificate.py * google.py * highlight.py * ifdef.py * import_diagnostics.py * lfcr.py * linktree.py * lll.py * mailerdaemon.py * make_ctype.py * mkreal.py * objgraph.py * pdeps.py * pickle2db.py * pindent.py * pysource.py * reindent-rst.py * rgrep.py * suff.py * texi2html.py * which.py Changes: * Remove test_fixcid, test_lll, test_pdeps and test_pindent of test.test_tools. * Remove get-remote-certificate.py changelog entry, since the script was removed. Note: there is a copy of crlf.py in Lib/test/test_lib2to3/data/.
@vstinner
Copy link
MemberAuthor

I completed to doc to mention the removal in What's New in Python 3.12 with a link to https://github.com/gvanrossum/old-demos

@vstinnervstinner merged commit 6cbbc26 into python:mainOct 4, 2022
@vstinnervstinner deleted the remove_scripts branch October 4, 2022 08:49
@vstinner
Copy link
MemberAuthor

Ok, I removed a first batch of outdated scripts.

vstinner added a commit that referenced this pull request Oct 11, 2022
Remove outdated example scripts of the Tools/scripts/ directory: * gprof2html.py * md5sum.py * nm2def.py * pathfix.py * win_add2path.py Remove test_gprof2html, test_md5sum and test_pathfix of test_tools.
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

7 participants

@vstinner@ericsnowcurrently@warsaw@gvanrossum@gpshead@ezio-melotti@bedevere-bot