Skip to content

Conversation

@yan12125
Copy link
Contributor

This #include is added in b744ba1 (issue8610) and later the use of CODESET is removed in d64e8a7 (issue9642).

Found this in investigating issue29436

This is a minor fix but my first patch on Github. Hope everything works :)

@yan12125
Copy link
ContributorAuthor

Sorry, but seems there are more. Please give me some time to check them one by one.

bltinmodule.c: Added in b744ba1 and no longer necessary since d64e8a7 posixmodule.c: Added in d1cd4d4 and no longer necessary since efb00c0 pythonrun.c: Added in 73d538b and no longer necessary since d600951 sysmodule.c: Added in 5467d4c and no longer necessary since a2c17c5
@yan12125yan12125 changed the title bpo-29556: Remove an unused #include from bltinmodule.cbpo-29556: Remove unused #include <langinfo.h>Feb 14, 2017
@vstinner
Copy link
Member

Still LGTM. Thanks for the commit numbers, it helped me to validate your change.

@vstinnervstinner merged commit 72e81d0 into python:masterFeb 15, 2017
@yan12125yan12125 deleted the remove-unused-include branch February 16, 2017 09:44
akruis pushed a commit to akruis/cpython that referenced this pull request Sep 9, 2017
… safe_pickle.c pickle_callback(). The bug is very old and might affect multiprocessing. The change fixes the bug and adds a test case. https://bitbucket.org/stackless-dev/stackless/issues/98 (grafted from 7cd2a4e39aa757427ccbf176ef7a0cd6f8f1514e)
akruis pushed a commit to akruis/cpython that referenced this pull request Sep 9, 2017
akruis pushed a commit to akruis/cpython that referenced this pull request Sep 9, 2017
…ed without threads. The test case needs threding. https://bitbucket.org/stackless-dev/stackless/issues/98 (grafted from 16c5769adf70810e23d480a51dddc60f34384251)
akruis pushed a commit to akruis/cpython that referenced this pull request Sep 9, 2017
akruis pushed a commit to akruis/cpython that referenced this pull request Sep 9, 2017
jaraco pushed a commit that referenced this pull request Dec 2, 2022
jaraco added a commit to jaraco/cpython that referenced this pull request Feb 17, 2023
ambv referenced this pull request in ambv/cpython Apr 8, 2025
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants

@yan12125@vstinner@the-knights-who-say-ni