Skip to content

Conversation

@gpshead
Copy link
Member

@gpsheadgpshead commented Oct 7, 2022

Converts the remaining importlib str.format() uses to f-strings.

@gpsheadgpshead added stdlib Standard Library Python modules in the Lib/ directory topic-importlib labels Oct 7, 2022
@gpsheadgpshead changed the title Convert remaining importlib format uses to f-str.gh-82874: Convert remaining importlib format uses to f-str.Oct 7, 2022
@gpsheadgpshead marked this pull request as ready for review October 7, 2022 00:41
Copy link
Member

@ericvsmithericvsmith left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Other than the one error, looks okay to me.

@bedevere-bot
Copy link

When you're done making the requested changes, leave the comment: I have made the requested changes; please review again.

@gpsheadgpshead merged commit 27369ef into python:mainOct 7, 2022
@gpsheadgpshead deleted the more-importlib-f-yes branch October 7, 2022 01:27
carljm added a commit to carljm/cpython that referenced this pull request Oct 8, 2022
* main: pythongh-86298: Ensure that __loader__ and __spec__.loader agree in warnings.warn_explicit() (pythonGH-97803) pythongh-82874: Convert remaining importlib format uses to f-str. (python#98005) Docs: Fix backtick errors found by sphinx-lint (python#97998) pythongh-97850: Remove deprecated functions from `importlib.utils` (python#97898) Remove extra spaces in custom openSSL documentation. (python#93568) pythonGH-90985: Revert "Deprecate passing a message into cancel()" (python#97999)
mpage pushed a commit to mpage/cpython that referenced this pull request Oct 11, 2022
@jaraco
Copy link
Member

I cherry-picked this to python/importlib_resources@222aaed5.

jaraco pushed a commit to jaraco/cpython that referenced this pull request Feb 17, 2023
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

stdlibStandard Library Python modules in the Lib/ directorytopic-importlib

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants

@gpshead@bedevere-bot@jaraco@brettcannon@ericvsmith