Skip to content

Conversation

@carljm
Copy link
Member

These memory leaks were recently introduced in #31787. Not sure if this fix qualifies as "trivial" or requires an issue also.

Before this fix, ./python -m test test_capi -R 3:3 reports a memory leak; after this fix it passes.

@kumaraditya303
Copy link
Contributor

@kumaraditya303 ➜ /workspaces/cpython (fixleak) $ ./python -m test test_capi -R 3:30:00:00 load avg: 0.98 Run tests sequentially0:00:00 load avg: 0.98 [1/1] test_capibeginning 6 repetitions123456......test_capi passed in 38.6 sec== Tests result: SUCCESS ==1 test OK.Total duration: 38.6 secTests result: SUCCESS

@kumaraditya303
Copy link
Contributor

@vstinner: This PR fixes ref leak on main. Currently all refleak buildbots are failing. See https://buildbot.python.org/all/#/release_status

@vstinner
Copy link
Member

You may want to use test.support.catch_unraisable_exception context manager, but it only stores the latest unraisable exception.

@carljm
Copy link
MemberAuthor

Thanks @vstinner, included the switch to catch_unraisable_exception in #98055

@carljmcarljm deleted the fixleak branch October 7, 2022 19:35
@vstinner
Copy link
Member

Thanks @vstinner, included the switch to catch_unraisable_exception in #98055

Thanks! I like the new test code.

mpage pushed a commit to mpage/cpython that referenced this pull request Oct 11, 2022
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants

@carljm@kumaraditya303@vstinner@JelleZijlstra@bedevere-bot