Skip to content

Conversation

@sterliakov
Copy link
Contributor

gh-98548: Workflow not equal operator spelling

This shell operator should be spelled as -ne, not as -neq. All shell binary operators are two symbols long.

This bug is present on 3.10 and 3.11 branches only.

This follows #98555 for another affected branch.

@bedevere-bot
Copy link

Most changes to Python require a NEWS entry.

Please add it using the blurb_it web app or the blurb command-line tool.

Copy link
Contributor

@hauntsaninjahauntsaninja left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for spotting this!

Here is an example workflow run affected: https://github.com/python/cpython/actions/runs/3293756628/jobs/5430563962
That said, I'm not sure this is enough of a fix, because I think Github Actions runs with bash -e. So I think we'd never get to this anyway? One option would be to use || (echo ... ; exit 1) or something

@sterliakov
Copy link
ContributorAuthor

Since the command expected to fail is short enough, maybe just

if! make check-abidump;thenecho ... fi

is sufficient? The if and until conditions are not considered failing for -e. Yes, gihub actions use set -e (or bash -e, not sure about this) to fail on first failing step.

@sterliakovsterliakov requested review from hauntsaninja and removed request for ezio-melottiOctober 24, 2022 10:09
Copy link
Contributor

@hauntsaninjahauntsaninja left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, this looks good to me. Want to update the 3.10 backport #98555 as well? :-) cc @JelleZijlstra

@sterliakov
Copy link
ContributorAuthor

Updated #98555 too.

@ambvambv merged commit 194588d into python:3.11Oct 28, 2022
encukou pushed a commit to encukou/cpython that referenced this pull request May 23, 2023
Backport the workflow change and fix-ups: - pythonGH-92442 (e89c01e) - pythonGH-94129 (0dadb22) - pythonGH-98556 (194588d) Co-Authored-By: sterliakov <50529348+sterliakov@users.noreply.github.com>
Yhg1s pushed a commit that referenced this pull request May 23, 2023
Backport the workflow change and fix-ups: - GH-92442 (e89c01e) - GH-94129 (0dadb22) - GH-98556 (194588d) Co-Authored-By: sterliakov <50529348+sterliakov@users.noreply.github.com> Co-authored-by: Hugo van Kemenade <hugovk@users.noreply.github.com> Co-authored-by: Pablo Galindo Salgado <Pablogsal@gmail.com>
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants

@sterliakov@bedevere-bot@hauntsaninja@ambv@JelleZijlstra@AlexWaygood