gh-98703: add tests for closing _ProactorSocketTransport with proactor event loop#98730
Uh oh!
There was an error while loading. Please reload this page.
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
kumaraditya303 added topic-asyncio skip issue skip news needs backport to 3.10 kumaraditya303 changed the title asyncio.StreamWriter with proactor event loop_ProactorSocketTransport with proactor event loop
kumaraditya303force-pushed the proactor-test branch from c8ec7e6 to 51ffb5dCompare
Fidget-Spinner changed the title _ProactorSocketTransport with proactor event loop_ProactorSocketTransport with proactor event loop
Member
Fidget-Spinner commented Oct 26, 2022
Skip news because it shares the same news item as #98704. |
kumaraditya303 requested review from 1st1, asvetlov and gvanrossum as code owners
Fidget-Spinner approved these changes Oct 27, 2022
Member
Fidget-Spinner commented Oct 27, 2022
These are great tests. It seems that they failed on every platform prior to the fix :)! |
Contributor
miss-islington commented Oct 27, 2022
Thanks @kumaraditya303 for the PR, and @Fidget-Spinner for merging it 🌮🎉.. I'm working now to backport this PR to: 3.10, 3.11. |
bedevere-bot commented Oct 27, 2022
GH-98755 is a backport of this pull request to the 3.11 branch. |
miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Oct 27, 2022
… proactor event loop (pythonGH-98730) (cherry picked from commit 96ae80f) Co-authored-by: Kumar Aditya <59607654+kumaraditya303@users.noreply.github.com>
bedevere-bot commented Oct 27, 2022
GH-98756 is a backport of this pull request to the 3.10 branch. |
miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Oct 27, 2022
… proactor event loop (pythonGH-98730) (cherry picked from commit 96ae80f) Co-authored-by: Kumar Aditya <59607654+kumaraditya303@users.noreply.github.com>
gvanrossum pushed a commit to gvanrossum/cpython that referenced this pull request Oct 28, 2022
… proactor event loop (pythonGH-98730)
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.