Skip to content

gh-98989: configure: add 3.11 to list of Pythons#98988

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
JelleZijlstra merged 3 commits into from
Nov 2, 2022
Merged

gh-98989: configure: add 3.11 to list of Pythons #98988

JelleZijlstra merged 3 commits into from
Nov 2, 2022

Conversation

@JelleZijlstra
Copy link
Member

@JelleZijlstraJelleZijlstra commented Nov 2, 2022•
edited by bedevere-bot
Loading

@JelleZijlstra
Copy link
MemberAuthor

JelleZijlstra commented Nov 2, 2022

I'll add an issue and NEWS since the bug went out in 3.12a1 and could affect some users.

gvanrossum
gvanrossum approved these changes Nov 2, 2022
View reviewed changes
Copy link
Member

@gvanrossumgvanrossum left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Don't take my word for it, this is probably up to @tiran or @brettcannon to review.

@JelleZijlstraJelleZijlstra changed the title configure: add 3.11 to list of Pythonsgh-98989: configure: add 3.11 to list of PythonsNov 2, 2022
@bedevere-botbedevere-bot mentioned this pull request Nov 2, 2022
Closed
hauntsaninja
hauntsaninja reviewed Nov 2, 2022
View reviewed changes
configure.ac

AC_CHECK_PROGS([PYTHON_FOR_REGEN],
[python$PACKAGE_VERSION python3.10 python3.9 python3.8 python3.7 python3.6 python3 python],
[python$PACKAGE_VERSION python3.11 python3.10 python3.9 python3.8 python3.7 python3.6 python3 python],
Copy link
Contributor

@hauntsaninjahauntsaninjaNov 2, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Worth queuing up a couple versions?

@hugovk
Copy link
Member

hugovk commented Nov 2, 2022

Something to add to PEP 101 (Doing Python Releases)?

kumaraditya303
kumaraditya303 reviewed Nov 2, 2022
View reviewed changes
configure.ac

AC_CHECK_PROGS([PYTHON_FOR_REGEN],
[python$PACKAGE_VERSION python3.10 python3.9 python3.8 python3.7 python3.6 python3 python],
[python$PACKAGE_VERSION python3.11 python3.10 python3.9 python3.8 python3.7 python3.6 python3 python],
Copy link
Contributor

@kumaraditya303kumaraditya303Nov 2, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why are we allowing python3.8 and lower in the first place if we know that 3.9+ is required?

Copy link
Contributor

@erlend-aaslanderlend-aaslandNov 2, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If 3.9 or higher is required, we should remove the earlier and incompatible versions.

Copy link
MemberAuthor

@JelleZijlstraJelleZijlstraNov 2, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Guido said he wanted to remove the 3.9+ dependency that crept into one of the scripts. Increasing the minimum required version might need more discussion as it could make bootstrapping harder for some.

Copy link
Contributor

@kumaraditya303kumaraditya303Nov 2, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ok sure let's get this in first as this is failing randomly on PRs.

Copy link
MemberAuthor

@JelleZijlstraJelleZijlstraNov 2, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@erlend-aasland any objections to landing this?

Copy link
Contributor

@erlend-aaslanderlend-aaslandNov 2, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nah, good to good for my part :)

@erlend-aaslanderlend-aasland self-assigned this Nov 2, 2022
@JelleZijlstra@erlend-aasland
Update Misc/NEWS.d/next/Build/2022-11-01-21-45-58.gh-issue-98989.tMxb…
3ca0188
…dB.rst Co-authored-by: Erlend E. Aasland <erlend.aasland@protonmail.com>
@JelleZijlstraJelleZijlstra mentioned this pull request Nov 2, 2022
Open
@JelleZijlstra
Copy link
MemberAuthor

JelleZijlstra commented Nov 2, 2022

Something to add to PEP 101 (Doing Python Releases)?

python/peps#2864

@JelleZijlstraJelleZijlstra merged commit f7241aa into python:mainNov 2, 2022
@JelleZijlstraJelleZijlstra deleted the fixconfig branch November 2, 2022 17:05
@kumaraditya303kumaraditya303 mentioned this pull request Nov 2, 2022
Merged
@JelleZijlstraJelleZijlstra mentioned this pull request Nov 2, 2022
Closed
@gvanrossumgvanrossum mentioned this pull request Nov 2, 2022
Closed
@erlend-aaslanderlend-aasland mentioned this pull request May 14, 2023
Closed
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@hauntsaninjahauntsaninjahauntsaninja left review comments

@erlend-aaslanderlend-aaslanderlend-aasland approved these changes

@kumaraditya303kumaraditya303kumaraditya303 left review comments

@gvanrossumgvanrossumgvanrossum approved these changes

Assignees

@erlend-aaslanderlend-aasland

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

7 participants

@JelleZijlstra@hugovk@gvanrossum@hauntsaninja@erlend-aasland@kumaraditya303@bedevere-bot