GH-90699: Remove _Py_IDENTIFIER usage from _asyncio module#99010
Uh oh!
There was an error while loading. Please reload this page.
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
kumaraditya303 requested review from 1st1, asvetlov and gvanrossum as code owners
kumaraditya303force-pushed the asyncio branch 2 times, most recently from 8e524e7 to dbddd5fCompare
Member
gvanrossum left a comment
gvanrossum left a comment There was a problem hiding this comment.
Interesting. I guess this makes it easier to convert this code to two-phase init?
Member
ericsnowcurrently commented Nov 2, 2022
Yep. Also, we're trying to get rid of |
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Automerge-Triggered-By: GH:ericsnowcurrently