GH-98831: Auto-generate PREDICTED() macro calls#99102
Merged
Uh oh!
There was an error while loading. Please reload this page.
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
This allows us to remove all PREDICTED() calls from bytecodes.c. The generated_cases.c.h file is unchanged.
brandtbucher approved these changes Nov 4, 2022
Member
brandtbucher left a comment
brandtbucher left a comment There was a problem hiding this comment.
Awesome!
This is exactly the sort of clean improvement I was hoping we could get out of this project... excited for more.
Uh oh!
There was an error while loading. Please reload this page.
Co-authored-by: Brandt Bucher <brandtbucher@gmail.com>
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This allows us to remove all PREDICTED() calls from bytecodes.c. The generated_cases.c.h file is unchanged.