Skip to content

GH-90699: disallow _Py_IDENTIFIER in core code #99210

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
miss-islington merged 3 commits into from
Nov 9, 2022
Merged

GH-90699: disallow _Py_IDENTIFIER in core code #99210

miss-islington merged 3 commits into from
Nov 9, 2022

Conversation

@kumaraditya303
Copy link
Contributor

@kumaraditya303kumaraditya303 commented Nov 7, 2022•
edited by miss-islington
Loading

Automerge-Triggered-By: GH:ericsnowcurrently

@bedevere-botbedevere-bot mentioned this pull request Nov 7, 2022
Closed
@kumaraditya303kumaraditya303 marked this pull request as ready for review November 8, 2022 05:52
ericsnowcurrently
ericsnowcurrently reviewed Nov 8, 2022
View reviewed changes
ericsnowcurrently
ericsnowcurrently approved these changes Nov 9, 2022
View reviewed changes
Copy link
Member

@ericsnowcurrentlyericsnowcurrently left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@miss-islingtonmiss-islington merged commit 6e3cc72 into python:mainNov 9, 2022
@ericsnowcurrently
Copy link
Member

ericsnowcurrently commented Nov 9, 2022

Thanks for working on this, @kumaraditya303!

@kumaraditya303kumaraditya303 deleted the disable-id branch November 9, 2022 17:51
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@ericsnowcurrentlyericsnowcurrentlyericsnowcurrently approved these changes

Assignees

No one assigned

Labels

skip news

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@kumaraditya303@ericsnowcurrently@bedevere-bot@miss-islington