Skip to content

GH-98219: reduce sleep time in asyncio subprocess test#99464

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
gvanrossum merged 2 commits into from
Nov 14, 2022
Merged

GH-98219: reduce sleep time in asyncio subprocess test #99464

gvanrossum merged 2 commits into from
Nov 14, 2022

Conversation

@kumaraditya303
Copy link
Contributor

@kumaraditya303kumaraditya303 commented Nov 14, 2022•
edited
Loading

Instead of 100000000, 2 is used so that the test still works but the process completes after 2 sec and hopefully avoid permission errors.

@bedevere-botbedevere-bot added awaiting review tests Tests in the Lib/test dir labels Nov 14, 2022
@bedevere-botbedevere-bot mentioned this pull request Nov 14, 2022
Closed
@kumaraditya303
Copy link
ContributorAuthor

kumaraditya303 commented Nov 14, 2022•
edited
Loading

FWIW this seems to only happen on very slow machines like Github Actions with Windows 10. I have tried to reproduce this on Windows 11 but no luck.

@kumaraditya303
Copy link
ContributorAuthor

kumaraditya303 commented Nov 14, 2022

Windows tests passed, triggering bots again to check again that it works. For reference previous run https://github.com/python/cpython/actions/runs/3460146711/jobs/5776365470

@gvanrossumgvanrossum merged commit 619cadc into python:mainNov 14, 2022
@gvanrossum
Copy link
Member

gvanrossum commented Nov 14, 2022

Should this be backported to 3.11?

@kumaraditya303kumaraditya303 deleted the reduce-sleep branch November 15, 2022 11:00
@kumaraditya303kumaraditya303 added the needs backport to 3.11 only security fixes label Nov 15, 2022
@miss-islington
Copy link
Contributor

miss-islington commented Nov 15, 2022

Thanks @kumaraditya303 for the PR, and @gvanrossum for merging it 🌮🎉.. I'm working now to backport this PR to: 3.11.
🐍🍒⛏🤖

@bedevere-bot
Copy link

bedevere-bot commented Nov 15, 2022

GH-99504 is a backport of this pull request to the 3.11 branch.

miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Nov 15, 2022
@kumaraditya303@miss-islington
pythonGH-98219: reduce sleep time inasynciosubprocess test (pytho…
a673707
…nGH-99464) (cherry picked from commit 619cadc) Co-authored-by: Kumar Aditya <59607654+kumaraditya303@users.noreply.github.com>
@bedevere-botbedevere-bot removed the needs backport to 3.11 only security fixes label Nov 15, 2022
@kumaraditya303
Copy link
ContributorAuthor

kumaraditya303 commented Nov 15, 2022

Should this be backported to 3.11?

Yes!

miss-islington added a commit that referenced this pull request Nov 15, 2022
@miss-islington@kumaraditya303
GH-98219: reduce sleep time inasynciosubprocess test (GH-99464)
e1e8a15
(cherry picked from commit 619cadc) Co-authored-by: Kumar Aditya <59607654+kumaraditya303@users.noreply.github.com>
@bedevere-bot
Copy link

bedevere-bot commented Nov 15, 2022

⚠️⚠️⚠️ Buildbot failure ⚠️⚠️⚠️

Hi! The buildbot PPC64LE Fedora Stable Clang Installed 3.11 has failed when building commit e1e8a15.

What do you need to do:

  1. Don't panic.
  2. Check the buildbot page in the devguide if you don't know what the buildbots are or how they work.
  3. Go to the page of the buildbot that failed (https://buildbot.python.org/all/#builders/1003/builds/439) and take a look at the build logs.
  4. Check if the failure is related to this commit (e1e8a15) or if it is a false positive.
  5. If the failure is related to this commit, please, reflect that on the issue and make a new Pull Request with a fix.

You can take a look at the buildbot page here:

https://buildbot.python.org/all/#builders/1003/builds/439

Summary of the results of the build (if available):

Click to see traceback logs
fatal: unable to access 'https://github.com/python/cpython.git/': Could not resolve host: github.comchmod: cannot access 'target/': No such file or directorymake: *** No rule to make target 'distclean'. Stop.

@bedevere-bot
Copy link

bedevere-bot commented Nov 15, 2022

⚠️⚠️⚠️ Buildbot failure ⚠️⚠️⚠️

Hi! The buildbot PPC64LE Fedora Stable Clang Installed 3.11 has failed when building commit e1e8a15.

What do you need to do:

  1. Don't panic.
  2. Check the buildbot page in the devguide if you don't know what the buildbots are or how they work.
  3. Go to the page of the buildbot that failed (https://buildbot.python.org/all/#builders/1003/builds/440) and take a look at the build logs.
  4. Check if the failure is related to this commit (e1e8a15) or if it is a false positive.
  5. If the failure is related to this commit, please, reflect that on the issue and make a new Pull Request with a fix.

You can take a look at the buildbot page here:

https://buildbot.python.org/all/#builders/1003/builds/440

Summary of the results of the build (if available):

Click to see traceback logs
fatal: unable to access 'https://github.com/python/cpython.git/': Could not resolve host: github.comchmod: cannot access 'target/': No such file or directorymake: *** No rule to make target 'distclean'. Stop.

@gvanrossum
Copy link
Member

gvanrossum commented Nov 15, 2022

Do the buildbot failures look like our fault?

CuriousLearner added a commit to CuriousLearner/cpython that referenced this pull request Nov 16, 2022
@CuriousLearner
Merge branch 'main' into fix-issue21914
abd206e
* main: (8272 commits) Update Windows readme.txt to clarify Visual Studio required versions (pythonGH-99522) pythongh-99460 Emscripten trampolines on optimized METH_O and METH_NOARGS code paths (python#99461) pythongh-92647: [Enum] use final status to determine lookup or create (pythonGH-99500) pythongh-81057: Move Globals in Core Code to _PyRuntimeState (pythongh-99496) Post 3.12.0a2 pythongh-99300: Use Py_NewRef() in Python/Python-ast.c (python#99499) pythongh-93649: Split pytime and datetime tests from _testcapimodule.c (python#99494) pythongh-99370: fix test_zippath_from_non_installed_posix (pythonGH-99483) pythonGH-99205: remove `_static` field from `PyThreadState` and `PyInterpreterState` (pythonGH-99385) pythongh-81057: Move the Remaining Import State Globals to _PyRuntimeState (pythongh-99488) pythongh-87604: Avoid publishing list of active per-interpreter audit hooks via the gc module (pythonGH-99373) pythongh-93649: Split getargs tests from _testcapimodule.c (python#99346) pythongh-81057: Move Global Variables Holding Objects to _PyRuntimeState. (pythongh-99487) pythonGH-98219: reduce sleep time in `asyncio` subprocess test (python#99464) pythonGH-99388: add `loop_factory` parameter to `asyncio.run` (python#99462) pythongh-99300: Use Py_NewRef() in PC/ directory (python#99479) pythongh-99300: Use Py_NewRef() in Doc/ directory (python#99480) pythongh-99300: Use Py_NewRef() in Modules/ directory (python#99473) pythongh-99300: Use Py_NewRef() in Modules/ directory (python#99469) pythongh-99370: Calculate zip path from prefix when in a venv (pythonGH-99371) ...
@arhadthedevarhadthedev mentioned this pull request Feb 6, 2023
Open
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@gvanrossumgvanrossumgvanrossum approved these changes

@1st11st1Awaiting requested review from 1st11st1 is a code owner

@asvetlovasvetlovAwaiting requested review from asvetlovasvetlov is a code owner

Assignees

No one assigned

Labels

skip newstestsTests in the Lib/test dirtopic-asyncio

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@kumaraditya303@gvanrossum@miss-islington@bedevere-bot