Uh oh!
There was an error while loading. Please reload this page.
- Notifications
You must be signed in to change notification settings - Fork 34k
gh-93649: Split watcher API tests from _testcapimodule.c#99532
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
gh-93649: Split watcher API tests from _testcapimodule.c #99532
Uh oh!
There was an error while loading. Please reload this page.
Conversation
sobolevn left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think we can also move class TestDictWatchers(unittest.TestCase): from test_capi/test_misc.py to its own python file: test_capi/test_dict_watchers.py
erlend-aasland commented Nov 16, 2022
That's a good idea. |
vstinner left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
First, I hesitated to suggest "dict" instead of "watchers", but it seems like there are many tests on dict watchers, so it's worth it to have separated files.
Can you rename watchers.c/py to dict_watchers.c/py?
I'm fine to leave the 4 other "dict" functions in _testcapi for now:
{"test_dict_iteration", test_dict_iteration, METH_NOARGS},{"dict_getitem_knownhash", dict_getitem_knownhash, METH_VARARGS},{"dict_get_version", dict_get_version, METH_VARARGS},{"clear_managed_dict", clear_managed_dict, METH_O, NULL}, erlend-aasland commented Nov 16, 2022
But there are also type watchers, and soon also function watchers. I figured all of these watcher APIs could live in the same place. Perhaps it will be too scattered with a new pair of files for each of these. |
vstinner commented Nov 16, 2022
Oh. I didn't notice that watchers are on different things. I was only aware of dict watchers. |
vstinner commented Nov 16, 2022
In this case, "watchers" is a perfect name. |
bedevere-bot commented Nov 16, 2022
|
bedevere-bot commented Nov 16, 2022
|
sobolevn commented Nov 16, 2022
I've opened #99544 about this crash. |
bedevere-bot commented Nov 16, 2022
|
bedevere-bot commented Nov 16, 2022
|
Uh oh!
There was an error while loading. Please reload this page.