gh-89653: PEP 670: Convert macros to functions#99843
Merged
Uh oh!
There was an error while loading. Please reload this page.
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
MemberAuthor
vstinner commented Nov 28, 2022
Convert macros to static inline functions to avoid macro pitfalls, like duplication of side effects: * DK_ENTRIES() * DK_UNICODE_ENTRIES() * PyCode_GetNumFree() * PyFloat_AS_DOUBLE() * PyInstanceMethod_GET_FUNCTION() * PyMemoryView_GET_BASE() * PyMemoryView_GET_BUFFER() * PyMethod_GET_FUNCTION() * PyMethod_GET_SELF() * PySet_GET_SIZE() * _PyHeapType_GET_MEMBERS() Changes: * Add also assertions in some functions using "CAST" macro to check the type of the arguments when Python is built with assertions (debug build). * Remove an outdated comment in unicodeobject.h. * PyCode_GetNumFree() doesn't cast its argument: the replaced macro already required the exact type PyCodeObject*. * PyCode_GetNumFree() casts PyCode_GetNumFree.co_nfreevars from int to Py_ssize_t to be future proof, and because Py_ssize_t is commonly used in the C API.
MemberAuthor
vstinner commented Nov 28, 2022
I changed PyCode_GetNumFree() return type to Py_ssize_t. |
erlend-aasland approved these changes Nov 28, 2022
MemberAuthor
vstinner commented Nov 28, 2022
See also PR #99844. |
MemberAuthor
vstinner commented Nov 28, 2022
Merged, thanks for the review @erlend-aasland. |
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Convert macros to static inline functions to avoid macro pitfalls,
like duplication of side effects:
Changes:
the type of the arguments when Python is built with assertions
(debug build).
already required the exact type PyCodeObject*.
to Py_ssize_t to be future proof, and because Py_ssize_t is
commonly used in the C API.