Fix: typo (Indention)#99904
Merged
Fix: typo (Indention) #99904
Uh oh!
There was an error while loading. Please reload this page.
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Example needed to be indented. Was trying to call a context manger `pr` (from ` with cProfile.Profile() as pr:`) wot perform ` pr.print_stats()` once it had already exited.
All commit authors signed the Contributor License Agreement. |
AlexWaygood previously requested changes Nov 30, 2022
Member
AlexWaygood left a comment
AlexWaygood left a comment There was a problem hiding this comment.
Looks good, but we need one more space of indentation. Also, please sign the CLA, or we won't be able to merge this, unfortunately :)
Uh oh!
There was an error while loading. Please reload this page.
bedevere-bot commented Nov 30, 2022
A Python core developer has requested some changes be made to your pull request before we can consider merging it. If you could please address their requests along with any other requests in other reviews from core developers that would be appreciated. Once you have made the requested changes, please leave a comment on this pull request containing the phrase |
Co-authored-by: Alex Waygood <Alex.Waygood@Gmail.com>
✅ Deploy Preview for python-cpython-preview ready!
To edit notification comments on pull requests, go to your Netlify site settings. |
Contributor
miss-islington commented Dec 12, 2022
Status check is done, and it's a success ✅. |
AlexWaygood added needs backport to 3.10 Contributor
miss-islington commented Dec 12, 2022
Thanks @jarrodcolburn for the PR 🌮🎉.. I'm working now to backport this PR to: 3.10. |
Contributor
miss-islington commented Dec 12, 2022
Thanks @jarrodcolburn for the PR 🌮🎉.. I'm working now to backport this PR to: 3.11. |
bedevere-bot commented Dec 12, 2022
GH-100195 is a backport of this pull request to the 3.10 branch. |
miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Dec 12, 2022
Example needed to be indented. Was trying to call a context manger `pr` (from ` with cProfile.Profile() as pr:`) wot perform ` pr.print_stats()` once it had already exited. (cherry picked from commit 8711b59) Co-authored-by: jarrodcolburn <jcourtlandcolburn@gmail.com> Automerge-Triggered-By: GH:AlexWaygood
bedevere-bot commented Dec 12, 2022
GH-100196 is a backport of this pull request to the 3.11 branch. |
miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Dec 12, 2022
Example needed to be indented. Was trying to call a context manger `pr` (from ` with cProfile.Profile() as pr:`) wot perform ` pr.print_stats()` once it had already exited. (cherry picked from commit 8711b59) Co-authored-by: jarrodcolburn <jcourtlandcolburn@gmail.com> Automerge-Triggered-By: GH:AlexWaygood
miss-islington added a commit that referenced this pull request Dec 12, 2022
Example needed to be indented. Was trying to call a context manger `pr` (from ` with cProfile.Profile() as pr:`) wot perform ` pr.print_stats()` once it had already exited. (cherry picked from commit 8711b59) Co-authored-by: jarrodcolburn <jcourtlandcolburn@gmail.com> Automerge-Triggered-By: GH:AlexWaygood
miss-islington added a commit that referenced this pull request Dec 12, 2022
Example needed to be indented. Was trying to call a context manger `pr` (from ` with cProfile.Profile() as pr:`) wot perform ` pr.print_stats()` once it had already exited. (cherry picked from commit 8711b59) Co-authored-by: jarrodcolburn <jcourtlandcolburn@gmail.com> Automerge-Triggered-By: GH:AlexWaygood
carljm added a commit to carljm/cpython that referenced this pull request Dec 14, 2022
* main: (103 commits) pythongh-100248: Add missing `ssl_shutdown_timeout` parameter in `asyncio` docs (python#100249) Assorted minor fixes for specialization stats. (pythonGH-100219) pythongh-100176: venv: Remove redundant compat code for Python <= 3.2 (python#100177) pythonGH-100222: Redefine _Py_CODEUNIT as a union to clarify structure of code unit. (pythonGH-100223) pythongh-99955: undef ERROR and SUCCESS before redefining (fixes sanitizer warning) (python#100215) pythonGH-100206: use versionadded for the addition of sysconfig.get_default_scheme (python#100207) pythongh-81057: Move _Py_RefTotal to the "Ignored Globals" List (pythongh-100203) pythongh-81057: Move Signal-Related Globals to _PyRuntimeState (pythongh-100085) pythongh-81057: Move faulthandler Globals to _PyRuntimeState (pythongh-100152) pythongh-81057: Move tracemalloc Globals to _PyRuntimeState (pythongh-100151) pythonGH-100143: Improve collecting pystats for parts of runs (pythonGH-100144) pythongh-99955: standardize return values of functions in compiler's code-gen (python#100010) pythongh-79218: Define `MS_WIN64` macro for Mingw-w64 64bit on Windows (pythonGH-100137) Fix: typo (Indention) (pythonGH-99904) pythongh-96715 Remove redundant NULL check in `profile_trampoline` function (python#96716) pythongh-100176: remove incorrect version compatibility check from argument clinic (python#100190) clarify the 4300-digit limit on int-str conversion (python#100175) pythongh-70393: Clarify mention of "middle" scope (python#98839) pythongh-99688: Fix outdated tests in test_unary (python#99712) pythongh-100174: [Enum] Correct PowersOfThree example. (pythonGH-100178) ...
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Example needed to be indented. Was trying to call a context manger
pr(fromwith cProfile.Profile() as pr:) wot performpr.print_stats()once it had already exited.Automerge-Triggered-By: GH:AlexWaygood