[3.11] gh-99845: _PyObject_DictPointer(): fix dictoffset cast#99922
Uh oh!
There was an error while loading. Please reload this page.
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Cast size_t to Py_ssize_t, rather than casting it to long. On 64-bit Windows, long is 32-bit whereas Py_ssize_t is 64-bit.
MemberAuthor
vstinner commented Dec 1, 2022
@serhiy-storchaka: I don't think that it deserves a NEWS entry, since it's unlikely that dictoffset is larger than |
serhiy-storchaka approved these changes Dec 1, 2022
Contributor
miss-islington commented Dec 1, 2022
Thanks @vstinner for the PR 🌮🎉.. I'm working now to backport this PR to: 3.10. |
miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Dec 1, 2022
bedevere-bot commented Dec 1, 2022
GH-99924 is a backport of this pull request to the 3.10 branch. |
MemberAuthor
vstinner commented Dec 1, 2022
@serhiy-storchaka: Merged, thanks for the review. |
miss-islington added a commit that referenced this pull request Dec 1, 2022
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Cast size_t to Py_ssize_t, rather than casting it to long. On 64-bit Windows, long is 32-bit whereas Py_ssize_t is 64-bit.