Uh oh!
There was an error while loading. Please reload this page.
- Notifications
You must be signed in to change notification settings - Fork 34k
[3.11] gh-93453: Only emit deprecation warning in asyncio.get_event_loop when a new event loop is created#99949
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[3.11] gh-93453: Only emit deprecation warning in asyncio.get_event_loop when a new event loop is created #99949
Conversation
serhiy-storchaka commented Dec 2, 2022 • edited by bedevere-bot
Loading Uh oh!
There was an error while loading. Please reload this page.
edited by bedevere-bot
Uh oh!
There was an error while loading. Please reload this page.
…op when a new event loop is created It no longer emits a deprecation warning if the current event loop was set.
ambv commented Dec 5, 2022
This will need to also be backported to 3.10. In the light of that, I'm nervous about the removal of @serhiy-storchaka, @gvanrossum, @kumaraditya303: would you be okay if I changed this PR to keep |
ambv commented Dec 5, 2022
Note that I'm fine with (I also resolved a conflict in any case to have CI green.) |
serhiy-storchaka commented Dec 5, 2022
I do not think it is necessary, but I have no objections. |
Uh oh!
There was an error while loading. Please reload this page.
ambv commented Dec 5, 2022
OK, @serhiy-storchaka, then I'll adapt this PR to leave |
gvanrossum left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Do read my comments first!
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
serhiy-storchaka commented Dec 6, 2022
I afraid that I can create conflicts with Łukasz, so from now I'm stopping committing in this branch. In any case my internet connection is currently too bad and can disappear at any time. |
ambv commented Dec 6, 2022
Thanks, @serhiy-storchaka, I reverted removal of asyncio.events._get_event_loop and _asyncio._get_event_loop. Look how obvious the remaining changes now look in the "Files changed" tab. I like this. I will wait for everything to pass and then merge this to create a 3.10 backport. |
miss-islington commented Dec 6, 2022
Thanks @serhiy-storchaka for the PR, and @ambv for merging it 🌮🎉.. I'm working now to backport this PR to: 3.10. |
miss-islington commented Dec 6, 2022
Sorry @serhiy-storchaka and @ambv, I had trouble checking out the |
ambv commented Dec 6, 2022
Note: I'm working on the backport now manually, there's some test conflicts with 3.10. |
…o.get_event_loop when a new event loop is created (pythonGH-99949) It no longer emits a deprecation warning if the current event loop was set. Co-authored-by: Łukasz Langa <lukasz@langa.pl> (cherry picked from commit 3fae04b) Co-authored-by: Serhiy Storchaka <storchaka@gmail.com>
It no longer emits a deprecation warning if the current event loop was set.