Skip to content

Conversation

@erlend-aasland
Copy link
Contributor

No description provided.

@erlend-aaslanderlend-aasland linked an issue Feb 22, 2023 that may be closed by this pull request
Copy link
Member

@CAM-GerlachCAM-Gerlach left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

FWIW, this looks good from a docs perspective—ultimately up to the subject matter experts (Ned, etc) of course.

@ned-deily
Copy link
Member

I like this approach but, as I've just discovered, Homebrew has just changed the game again by making their tcl-tk formula no longer "keg-only". As noted here, we should re-think this a bit in that light. I'll have some more thoughts on it soon.

@ned-deilyned-deily added the status-do not merge Do not merge the PR label Feb 26, 2023
@erlend-aasland
Copy link
ContributorAuthor

I like this approach but, as I've just discovered, Homebrew has just changed the game again by making their tcl-tk formula no longer "keg-only". As noted here, we should re-think this a bit in that light. I'll have some more thoughts on it soon.

Ouch, it's unfortunate that our build instructions are so dependent on Homebrew distribution specifics. Let's create a separate issue for this (unless you already did so).

@erlend-aaslanderlend-aasland marked this pull request as draft March 10, 2023 11:27
@erlend-aasland
Copy link
ContributorAuthor

As noted python/cpython#102186 (comment), we should re-think this a bit in that light. I'll have some more thoughts on it soon.

I've marked this as a draft until the above has landed.

@erlend-aasland
Copy link
ContributorAuthor

erlend-aasland commented Mar 22, 2023

I like this approach but, as I've just discovered, Homebrew has just changed the game again by making their tcl-tk formula no longer "keg-only". As noted here, we should re-think this a bit in that light. I'll have some more thoughts on it soon.

@ned-deily, have you had the chance to think about this issue? IMO, it is unfortunate that we rely on Homebrew specifics. Perhaps the best thing to do, is to update the devguide recommendations for how to install the dependencies:

$ brew install pkg-config openssl@1.1 xz gdbm tcl-tk $ brew link tcl-tk # <= may produce a warning if already linked

We can then carry on with this PR (and also update the devguide build steps again).

@ned-deily
Copy link
Member

@ned-deily, have you had the chance to think about this issue? IMO, it is unfortunate that we rely on Homebrew specifics. Perhaps the best thing to do, is to update the devguide recommendations for how to install the dependencies:

That could be an option. There are a number of other side issues with some of the other dependencies, like which ones should we use from the operating system, and there are the Homebrew differences between Intel and Apple Silicon installations. Alas, I am away right now but will get back to this in a couple of weeks. If you think there is a need to update the guide sooner, we can always tweak it again later.

@erlend-aasland
Copy link
ContributorAuthor

No, there's no hurry 🙂 If you're coming to SLC, we can discuss it there. If not, let's pick it up when you're ready.

@erlend-aaslanderlend-aasland marked this pull request as ready for review June 8, 2023 20:35
@erlend-aasland
Copy link
ContributorAuthor

@ned-deily, let's land this. We can handle the OpenSSL version in a follow-up PR (python/cpython#99079 (comment))

Copy link
Member

@ned-deilyned-deily left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks!

Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

status-do not mergeDo not merge the PR

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Use targeted env vars for macOS build instructions

4 participants

@erlend-aasland@ned-deily@CAM-Gerlach@ezio-melotti