Uh oh!
There was an error while loading. Please reload this page.
- Notifications
You must be signed in to change notification settings - Fork 964
Use targeted env vars for overriding compiler/linker args on macOS#1058
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Uh oh!
There was an error while loading. Please reload this page.
Conversation
CAM-Gerlach left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
FWIW, this looks good from a docs perspective—ultimately up to the subject matter experts (Ned, etc) of course.
ned-deily commented Feb 26, 2023
I like this approach but, as I've just discovered, Homebrew has just changed the game again by making their tcl-tk formula no longer "keg-only". As noted here, we should re-think this a bit in that light. I'll have some more thoughts on it soon. |
erlend-aasland commented Feb 27, 2023
Ouch, it's unfortunate that our build instructions are so dependent on Homebrew distribution specifics. Let's create a separate issue for this (unless you already did so). |
Uh oh!
There was an error while loading. Please reload this page.
erlend-aasland commented Mar 10, 2023
I've marked this as a draft until the above has landed. |
erlend-aasland commented Mar 22, 2023 • edited
Loading Uh oh!
There was an error while loading. Please reload this page.
edited
Uh oh!
There was an error while loading. Please reload this page.
@ned-deily, have you had the chance to think about this issue? IMO, it is unfortunate that we rely on Homebrew specifics. Perhaps the best thing to do, is to update the devguide recommendations for how to install the dependencies: $ brew install pkg-config openssl@1.1 xz gdbm tcl-tk $ brew link tcl-tk # <= may produce a warning if already linkedWe can then carry on with this PR (and also update the |
ned-deily commented Mar 28, 2023
That could be an option. There are a number of other side issues with some of the other dependencies, like which ones should we use from the operating system, and there are the Homebrew differences between Intel and Apple Silicon installations. Alas, I am away right now but will get back to this in a couple of weeks. If you think there is a need to update the guide sooner, we can always tweak it again later. |
erlend-aasland commented Mar 28, 2023
No, there's no hurry 🙂 If you're coming to SLC, we can discuss it there. If not, let's pick it up when you're ready. |
Uh oh!
There was an error while loading. Please reload this page.
erlend-aasland commented Jun 8, 2023
@ned-deily, let's land this. We can handle the OpenSSL version in a follow-up PR (python/cpython#99079 (comment)) |
ned-deily left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, thanks!
No description provided.