Skip to content

Conversation

@lorenzo-delsignore
Copy link
Contributor

@lorenzo-delsignorelorenzo-delsignore commented Aug 14, 2024

This pull request fixes#1366 issue by adding the htmllive command to the make.bat script.


📚 Documentation preview 📚: https://cpython-devguide--1373.org.readthedocs.build/

@ghost
Copy link

ghost commented Aug 14, 2024

All commit authors signed the Contributor License Agreement.
CLA signed

@ezio-melottiezio-melotti self-assigned this Aug 14, 2024
Copy link
Member

@ezio-melottiezio-melotti left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Can someone on Windows verify that it works as expected?

Co-authored-by: Hugo van Kemenade <1324225+hugovk@users.noreply.github.com>
@lorenzo-delsignore
Copy link
ContributorAuthor

lorenzo-delsignore commented Aug 14, 2024

I think that renaming the variables of SPHINXBUILD and SPHINXAUTOBUILD with something more readable will need a change of the Makefile of Linux too to be consistent. The problem is that the Makefile use only SPHINXBUILD variable, instead with Windows I only found this solution. In my opinion is better to mantain these two variables in the make.bat file.

@hugovk
Copy link
Member

Sure, we can keep the ALLONEWORD ones in this PR. Thanks!

@AA-Turner
Copy link
Member

Resolved merge conflicts, given I created them.

A

@ezio-melottiezio-melotti merged commit b603868 into python:mainSep 2, 2024
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Add htmllive target to make.bat

4 participants

@lorenzo-delsignore@hugovk@AA-Turner@ezio-melotti