Skip to content

Note how to translate python-docs-theme#1650

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
encukou merged 4 commits into from
Sep 12, 2025
Merged

Note how to translate python-docs-theme#1650

encukou merged 4 commits into from
Sep 12, 2025

Conversation

@StanFromIreland
Copy link
Member

@StanFromIrelandStanFromIreland commented Sep 8, 2025•
edited by github-actions bot
Loading

Closes#1649

📚 Documentation preview 📚: https://cpython-devguide--1650.org.readthedocs.build/

lysnikolaou
lysnikolaou reviewed Sep 9, 2025
View reviewed changes
Copy link
Member

@lysnikolaoulysnikolaou left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Left just one minor comment. Thanks @StanFromIreland!

@StanFromIreland@lysnikolaou
Revert wording change
2fcf57b
Co-authored-by: Lysandros Nikolaou <[email protected]>
lysnikolaou
lysnikolaou approved these changes Sep 9, 2025
View reviewed changes
Copy link
Member

@lysnikolaoulysnikolaou left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

rffontenelle
rffontenelle suggested changes Sep 9, 2025
View reviewed changes
Copy link
Contributor

@rffontenellerffontenelle left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for updating the docs with this. I have only one syntax fix and then LGTM.

@StanFromIreland@rffontenelle
Fix link
6cf0bf5
Co-authored-by: Rafael Fontenelle <[email protected]>
hugovk
hugovk reviewed Sep 10, 2025
View reviewed changes
@StanFromIreland@hugovk
Apply suggestions from code review
4e4724e
Co-authored-by: Hugo van Kemenade <[email protected]>
@encukouencukou merged commit 7ef583e into python:mainSep 12, 2025
4 checks passed
@StanFromIrelandStanFromIreland deleted the translation/python-docs-theme branch September 12, 2025 06:56
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@hugovkhugovkhugovk approved these changes

@lysnikolaoulysnikolaoulysnikolaou approved these changes

@willingcwillingcAwaiting requested review from willingc

@rffontenellerffontenelleAwaiting requested review from rffontenelle

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Feature: Note how to translate python-docs-theme

5 participants

@StanFromIreland@hugovk@rffontenelle@lysnikolaou@encukou