Update venv and clean make targets#856
Merged
Uh oh!
There was an error while loading. Please reload this page.
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
hugovk approved these changes May 6, 2022
| clean: clean-venv | ||
| -rm -rf $(BUILDDIR)/* | ||
| clean-venv: |
Member
There was a problem hiding this comment.
Should we include clean-venv in the help?
MemberAuthor
There was a problem hiding this comment.
It isn't included in CPython, and I think that's because:
- if you try to recreate the venv, it already tells you to use
make clean-venv - if you run
make cleanit also cleans the venv
Because of these reasons and for consistency with CPython, I decided to leave it out.
Member
hugovk commented May 6, 2022
Good to have things working in a similar way here and for CPython docs 👍 |
This was referenced May 15, 2022
AA-Turner pushed a commit to AA-Turner/devguide that referenced this pull request Jun 17, 2022
* Update the `venv` command in the Makefile. * Add the `clean-env` and updated the `clean` command.
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR:
venvtargetclean-venvtargetcleantarget to callclean-venvtooThese are copied from
cpython/Doc/Makefilewith minor changes.See #854.