Skip to content

Conversation

@Darnokiv
Copy link
Contributor

Deleted the duplicated paragraph "Committing Changes" (already in the paragraph "Staging and Committing Files") and changed "git add" to "git add -p". All accordingly to #888

Deleted the duplicated paragraph "Committing Changes" (already in the paragraph "Staging and Committing Files") and changed "git add" to "git add -p". All accordingly to #888
@ghost
Copy link

ghost commented Jun 18, 2022

All commit authors signed the Contributor License Agreement.
CLA signed

@Darnokiv
Copy link
ContributorAuthor

Sadly, I'm getting an error trying to sign the CLA. Are there any other ways to sign this?

Copy link
Member

@hugovkhugovk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

@hugovk
Copy link
Member

Sadly, I'm getting an error trying to sign the CLA. Are there any other ways to sign this?

Thanks for trying! There are other ways to sign, but I think they may be paper-based. The error is a known issue -- geldata/cla-bot#50 -- hopefully it'll be fixed soon so let's just wait a week or so. I'll give that issue a ping as well.

@DarnokivDarnokiv marked this pull request as ready for review June 18, 2022 15:16
@Darnokiv
Copy link
ContributorAuthor

Thanks for trying! There are other ways to sign, but I think they may be paper-based. The error is a known issue -- edgedb/cla-bot#50 -- hopefully it'll be fixed soon so let's just wait a week or so. I'll give that issue a ping as well.

Thank you very much, I will do that!

 Corrected a mistake with "git add -p" and added the normal "git add" command again Co-authored-by: Ezio Melotti <ezio.melotti@gmail.com>
@DarnokivDarnokiv requested a review from hugovkJune 19, 2022 08:29
@ambv
Copy link
Contributor

ambv commented Jun 20, 2022

@Darnokiv can you try signing the CLA again?

@Darnokiv
Copy link
ContributorAuthor

@Darnokiv can you try signing the CLA again?

I still get the same error, for me (but I'm an absolute beginner) it looks like the noreply-email cannot be related with my GitHub account

Thank you for authorizing our application, but the CLA must be signed by the users who contributed to the PR. Authors emails are: 85449868+Darnokiv@users.noreply.github.com.

@ambv
Copy link
Contributor

ambv commented Jun 20, 2022

Thanks for testing. I made changes that fixed what seems to be a subset of the problems people were seeing. Your situation is still a bit different it seems. I'm investigating further! Thank you for your patience.

@Darnokiv
Copy link
ContributorAuthor

Thank you for searching the issue! Let me know, when you need more info on my setup to raise the error or you need me to test again

@Darnokiv
Copy link
ContributorAuthor

@ambv, I just tried the signing again and it worked

@ambv
Copy link
Contributor

ambv commented Jun 20, 2022

Thanks for checking, @Darnokiv!

@ezio-melottiezio-melotti merged commit 2714ab8 into python:mainJun 22, 2022
@ezio-melottiezio-melotti self-assigned this Jun 22, 2022
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants

@Darnokiv@hugovk@ambv@ezio-melotti