Skip to content

move environment vars to a configuration file#269

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
AA-Turner merged 4 commits into from
Apr 11, 2025
Merged

move environment vars to a configuration file #269

AA-Turner merged 4 commits into from
Apr 11, 2025

Conversation

@ewdurbin
Copy link
Member

@ewdurbinewdurbin commented Apr 11, 2025

ref #266

This will allow us to write these files out to disk from python/psf-salt, and ensure they're picked up whenever/however build_docs.py is executed.

@ewdurbinewdurbin mentioned this pull request Apr 11, 2025
Open
AA-Turner
AA-Turner reviewed Apr 11, 2025
View reviewed changes
Copy link
Member

@AA-TurnerAA-Turner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

ewdurbinand others added 2 commits April 11, 2025 14:17
@ewdurbin@AA-Turner
Apply suggestions from code review
6325e5c
Co-authored-by: Adam Turner <9087854+AA-Turner@users.noreply.github.com>
@ewdurbin
move configuration handling into main, for logging
cd081de
@ewdurbinewdurbin mentioned this pull request Apr 11, 2025
Merged
@ewdurbin
Copy link
MemberAuthor

ewdurbin commented Apr 11, 2025

python/psf-salt#561

@ewdurbinewdurbin requested a review from AA-TurnerApril 11, 2025 18:28
AA-Turner
AA-Turner approved these changes Apr 11, 2025
View reviewed changes
Copy link
Member

@AA-TurnerAA-Turner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I've pushed 78a70a7 (#269) to factor out the envvar config to a function.

A

@AA-TurnerAA-Turner merged commit bd0e222 into mainApr 11, 2025
8 checks passed
@AA-TurnerAA-Turner deleted the config_file branch April 11, 2025 18:49
@ewdurbinewdurbin mentioned this pull request Jan 6, 2026
Merged
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@AA-TurnerAA-TurnerAA-Turner approved these changes

@hugovkhugovkAwaiting requested review from hugovk

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@ewdurbin@AA-Turner