- Notifications
You must be signed in to change notification settings - Fork 1
Create the Python Docs Editorial Board static site using Hugo#13
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Uh oh!
There was an error while loading. Please reload this page.
Conversation
netlifybot commented Aug 21, 2024 • edited
Loading Uh oh!
There was an error while loading. Please reload this page.
edited
Uh oh!
There was an error while loading. Please reload this page.
✅ Deploy Preview for pythoneditorialboard ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
nedbat commented Aug 21, 2024
This is great! The theme is a bit subtle. In light mode, I can't tell what words are links. Dark mode has a bit more contrast, but still seems to be hiding the links a bit. Are there other easy options? |
Mariatta commented Aug 21, 2024
Hmm I can try adjusting the CSS. Do you want colors to be different, or would adding underlines work? Usually I don't like customizing theme because I don't want to maintain it, and also I only have newbie-level CSS knowledge. But if others can help adjust and maintain the CSS then I'm ok with customization. I tried looking at some other minimalistic and lightweight Hugo themes, but many are outdated/maintained, like their demo site doesn't even work. This theme still seemed to be well maintained. Another theme I can try to work with is: https://docs.vantage-design.com/ace/ . Would this be of interest? |
AA-Turner commented Aug 21, 2024
Out of curiosity, would a Sphinx project be considered here? Though less 'landing page' like, it does have advantages in that it allows cross-linking to other Python docs sites and vice versa. I'm a little biased perhaps, but themes like Furo have well tested designs that we use for example in the docs-community site, whereas I don't see Hugo used as often. A |
Mariatta commented Aug 21, 2024
To me, Sphinx is too heavy-weight for this purpose. I like using Sphinx for documentation because of the cross-linking feature and auto API documentation, but even I, as an experienced Python user, struggled with it when trying to use it for things like personal blog/website. I found having to spend more time configuring and setting it up, disabling certain features, adjusting template, instead of writing content. Maybe some themes have made it easier, but it still a developer-focused framework. Whereas Hugo is built for website/landing page/blogging, which is the main purpose for this site. I don't know any Golang, but I could set it up and start writing content quickly, so I chose to optimize for this. The main consumable content on this site is the markdown files under We haven't use Hugo static site before within the CPython core team, so perhaps you can consider this as a small trial for a small site that has a small audience to begin with. I hope we don't need to keep arguing about which tools we use here, because in my mind, both tools are good, both have its own pro and cons, both produces a static site. I think the output static site is more important than the tool being used to build it. |
hugovk commented Aug 21, 2024
Underlines in main body text are a big plus for accessibility. WCAG guidelines say colour alone shouldn't be used for these prose links. This doesn't necessarily apply to th ig lime navigation, header and footer links, like the grid of links to the minutes from the homepage. For more info, see references in python/python-docs-theme#160 and python/python-docs-theme#169. |
gvanrossum commented Aug 21, 2024
Big yes for underlines from a geezer with declining eyesight. |
Mariatta commented Aug 21, 2024
I added a custom css to underline links, please check the output: https://deploy-preview-13--pythoneditorialboard.netlify.app/ I also updated the readme with instructions on how to write up new content/updates. Sample screenshots: Landing Page/updates/ page/archives/ page/search/ page |
nedbat commented Aug 21, 2024
Looks great, thanks! |
AA-Turner commented Aug 21, 2024
No argument intended, and as you note form follows function. If nothing else, I consider this useful feedback! A |
hugovk left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Underlines look good, thanks!
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
willingc left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @Mariatta. Let's give this a try. We can always adapt to another framework if the need arises. Results on lighthouse look good (SEO could be inched up in the future). 💐
willingc commented Aug 22, 2024
Add some templates. Fix typo in update entry. Update readme with info on how to write new content.




Features: