readers: add MultiplexedPath.paths#310
Open
+4 −0
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Signed-off-by: Filipe Laíns <lains@riseup.net>
MemberAuthor
FFY00 commented Jun 26, 2024
@jaraco what do you think of this? |
jaraco requested changes Jun 26, 2024
Member
jaraco left a comment
jaraco left a comment There was a problem hiding this comment.
Seems reasonable to me. We should add some tests to ensure the use-case is covered. And should we include type annotations?
jaraco reviewed Aug 20, 2024
| @property | ||
| defpaths(self): | ||
| returnself._paths.copy() |
Member
There was a problem hiding this comment.
If we type-annotate this property to be a non-mutable Sequence, and because self._paths is not mutated internally (also treated like a non-mutable Sequence), there's no need to make a copy. But I'm okay either way.
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes#309