[mypyc] Add support for building mypyc code on WASM#13446
Merged
Uh oh!
There was an error while loading. Please reload this page.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This PR tweaks two things about how mypyc generates and builds C code to better support WebAssembly. First, we search
sysconfigfor the size ofsize_t, which works much better for cross-compiling. Second, newer versions of clang have-Wno-unused-but-set-variableand so it is added to the default list of arguments (this should probably land regardless the decision on merging this PR).Test Plan
This PR depends on #13445. To test this PR, you can do the following:
assuming mypy checkout with both PRs applied, must be on Python 3.10(!)
Note: you will get a warning about using
--global-option, you can ignore it for now. I'm trying to find out why--build-optionisn't working...