Skip to content

Conversation

@AlexWaygood
Copy link
Member

@AlexWaygoodAlexWaygood commented Aug 18, 2022

This is a PR to the jhance-typeshed branch. This PR should make CI on #13386 go green.

@AlexWaygoodAlexWaygood mentioned this pull request Aug 18, 2022
@AlexWaygoodAlexWaygood changed the title Fix teststubtestFix teststubtest for the upcoming typeshed syncAug 18, 2022
Copy link
Member

@sobolevnsobolevn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Have you tried this locally? Error does seem too cryptic to me 🙁

@AlexWaygood
Copy link
MemberAuthor

AlexWaygood commented Aug 18, 2022

Have you tried this locally? Error does seem too cryptic to me 🙁

Yep, I tried it locally with #13386 checked out. I reproduced the test failure in CI locally without this patch applied, and confirmed that teststubtest passes with this change applied :)

@AlexWaygood
Copy link
MemberAuthor

AlexWaygood commented Aug 18, 2022

Anyhow, this is a PR to the jhance-typeshed branch that's being used for #13386, so if the CI on this PR goes green, we'll know it fixes the issue.

@JelleZijlstraJelleZijlstra merged commit 2ec37f5 into python:jhance-typeshedAug 19, 2022
@AlexWaygoodAlexWaygood deleted the jhance-typeshed branch August 19, 2022 03:28
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants

@AlexWaygood@sobolevn@JelleZijlstra