Skip to content

Conversation

@JulienPalard
Copy link
Member

Do not merge before python/cpython#20969.

@JulienPalard
Copy link
MemberAuthor

JulienPalard commented Jun 19, 2020

@ambv@pablogsal@ned-deily you're concerned by this one, don't hesitate to tell me if the wording is not clear.

TL;DR: Changes to indexsidebar.html and switchers.js in all branches are no longer needed, (a change in docsbuild-script is still needed).

Copy link
Member

@ned-deilyned-deily left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thanks for making all those changes. Once the doc build changes are fully deployed, this should be merged as well.

@brettcannonbrettcannon marked this pull request as draft September 21, 2020 16:55
@JulienPalardJulienPalard changed the title [WIP] PEP 101: Simplified due to centralisation of switchers in the doc.PEP 101: Simplified due to centralisation of switchers in the doc.Nov 7, 2020
@JulienPalardJulienPalard marked this pull request as ready for review November 7, 2020 10:42
@JulienPalardJulienPalard merged commit f2213d7 into python:masterNov 7, 2020
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants

@JulienPalard@ned-deily@the-knights-who-say-ni