Skip to content

Conversation

@AA-Turner
Copy link
Member

@AA-TurnerAA-Turner commented Jan 24, 2022

RE #2151; fixes Sphinx build.

A

@CAM-GerlachCAM-Gerlach changed the title Exclude .codeowners from SphinxExclude .codespell from SphinxJan 24, 2022
@JelleZijlstraJelleZijlstra merged commit 94b32ce into python:mainJan 24, 2022
@AA-Turner
Copy link
MemberAuthor

Good god I'm bad on getting things mixed up in PR titles -- first RST vs RFC, now codeowners vs codespell 😁

Thanks for merging Jelle

@CAM-Gerlach
Copy link
Member

CAM-Gerlach commented Jan 24, 2022

Happens to all of us 😆 Luckily I fixed it with a few seconds to spare :)

This is going to keep happening whenever anyone add .txt files to the repo, whether as config or as a PEP supplement. Is there any way we can specifically match only \.rst$|^/pep-[0-9]{4}\.txt$, or at least only .txt (but not.rst) in the root?

@AA-Turner
Copy link
MemberAuthor

AA-Turner commented Jan 25, 2022

Ideally I'd whitelist to include_patterns = ["pep-????"], but Sphinx doesn't support include_patterns. (Need to get a second to submit a feature request & implementation upstream)

The build on PRs going forwards will make it much easier to catch in the future, though.

A

Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants

@AA-Turner@CAM-Gerlach@JelleZijlstra@the-knights-who-say-ni