Skip to content
/pepsPublic

Add Typing Topic#2670

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
JelleZijlstra merged 7 commits into from
Oct 7, 2022
Merged

Add Typing Topic #2670

JelleZijlstra merged 7 commits into from
Oct 7, 2022

Conversation

@JelleZijlstra
Copy link
Member

@JelleZijlstraJelleZijlstra commented Jun 25, 2022

No description provided.

CAM-Gerlach
CAM-Gerlach reviewed Jun 25, 2022
View reviewed changes
@JelleZijlstraJelleZijlstra marked this pull request as ready for review July 1, 2022 15:13
CAM-Gerlach
CAM-Gerlach reviewed Jul 2, 2022
View reviewed changes
Copy link
Member

@CAM-GerlachCAM-Gerlach left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

At least in the packaging PEPs, we put the Topic below the Type, which seems to make sense, so probably worth being consistent here like the other headers are.

Also, one wording suggestion.

@CAM-GerlachCAM-Gerlach added enhancement meta Related to the repo itself and its processes labels Jul 2, 2022
@CAM-GerlachCAM-Gerlach changed the title Add typing TopicAdd Typing TopicOct 7, 2022
CAM-Gerlach
CAM-Gerlach approved these changes Oct 7, 2022
View reviewed changes
Copy link
Member

@CAM-GerlachCAM-Gerlach left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM now; thanks @JelleZijlstra

@JelleZijlstraJelleZijlstra merged commit 83b976d into python:mainOct 7, 2022
@JelleZijlstraJelleZijlstra deleted the topictyping branch October 7, 2022 00:36
@hugovk
Copy link
Member

hugovk commented Oct 7, 2022

And it's live!

https://peps.python.org/topic/typing/

Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@CAM-GerlachCAM-GerlachCAM-Gerlach approved these changes

@gvanrossumgvanrossumAwaiting requested review from gvanrossum

@larryhastingslarryhastingsAwaiting requested review from larryhastings

@ilevkivskyiilevkivskyiAwaiting requested review from ilevkivskyi

@ambvambvAwaiting requested review from ambv

@lisroachlisroachAwaiting requested review from lisroach

@AA-TurnerAA-TurnerAwaiting requested review from AA-TurnerAA-Turner is a code owner

Assignees

No one assigned

Labels

enhancementmetaRelated to the repo itself and its processes

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@JelleZijlstra@hugovk@CAM-Gerlach