Skip to content
/pepsPublic

PEP 8104: 2023 Term Steering Council election#2875

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
ewdurbin merged 6 commits into from
Nov 14, 2022
Merged

PEP 8104: 2023 Term Steering Council election #2875

ewdurbin merged 6 commits into from
Nov 14, 2022

Conversation

@ewdurbin
Copy link
Member

@ewdurbinewdurbin commented Nov 8, 2022

Initial draft with pertinent dates and details.

@ewdurbinewdurbin requested a review from a team as a code ownerNovember 8, 2022 20:31
JelleZijlstra
JelleZijlstra reviewed Nov 8, 2022
View reviewed changes
@ewdurbin@JelleZijlstra
Updatepep-8104.rst
7057c93
Co-authored-by: Jelle Zijlstra <jelle.zijlstra@gmail.com>
@CAM-GerlachCAM-Gerlach changed the title PEP 8104 - 2023 Term Steering Council electionPEP 8104: 2023 term Steering Council electionNov 8, 2022
@CAM-GerlachCAM-Gerlach added the new-pep A new draft PEP submitted for initial review label Nov 8, 2022
AA-Turner
AA-Turner reviewed Nov 8, 2022
View reviewed changes
Copy link
Member

@AA-TurnerAA-Turner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Elided two blocks that are no longer needed:

A

ewdurbinand others added 2 commits November 8, 2022 17:27
@ewdurbin@AA-Turner
Updatepep-8104.rst
7048570
Co-authored-by: Adam Turner <9087854+AA-Turner@users.noreply.github.com>
@ewdurbin@AA-Turner
Updatepep-8104.rst
a71642f
Co-authored-by: Adam Turner <9087854+AA-Turner@users.noreply.github.com>
CAM-Gerlach
CAM-Gerlach reviewed Nov 8, 2022
View reviewed changes
@CAM-GerlachCAM-Gerlach changed the title PEP 8104: 2023 term Steering Council electionPEP 8104: 2023 Term Steering Council electionNov 8, 2022
@ewdurbin@CAM-Gerlach
Apply suggestions from code review
ffbf766
Co-authored-by: C.A.M. Gerlach <CAM.Gerlach@Gerlach.CAM>
CAM-Gerlach
CAM-Gerlach approved these changes Nov 8, 2022
View reviewed changes
Copy link
Member

@CAM-GerlachCAM-Gerlach left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks @ewdurbin

Unrelated, but as I was reminded by how easy it was to just check the preview as opposed to a manual local build, and we've all been eagerly looking forward to it...can we get the docs previews enabled now? :)

@JelleZijlstra
Copy link
Member

JelleZijlstra commented Nov 8, 2022

Do you mean something else than https://pep-previews--2875.org.readthedocs.build/pep-8104/ ?

@CAM-Gerlach
Copy link
Member

CAM-Gerlach commented Nov 8, 2022

hugovk
hugovk reviewed Nov 8, 2022
View reviewed changes
brettcannon
brettcannon requested changes Nov 9, 2022
View reviewed changes
Copy link
Member

@brettcannonbrettcannon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think we should get the times consistent by only specifying AoE or UTC (my vote is AoE).

@ewdurbinewdurbin merged commit c1d17d8 into mainNov 14, 2022
@ewdurbinewdurbin deleted the 2023_term_sc_election branch November 14, 2022 13:36
CAM-Gerlach
CAM-Gerlach reviewed Nov 14, 2022
View reviewed changes
@ewdurbinewdurbin mentioned this pull request Dec 6, 2022
Closed
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@JelleZijlstraJelleZijlstraJelleZijlstra left review comments

@hugovkhugovkhugovk left review comments

@AA-TurnerAA-TurnerAA-Turner left review comments

@CAM-GerlachCAM-GerlachCAM-Gerlach approved these changes

@brettcannonbrettcannonAwaiting requested review from brettcannon

Assignees

No one assigned

Labels

new-pepA new draft PEP submitted for initial review

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

7 participants

@ewdurbin@JelleZijlstra@CAM-Gerlach@brettcannon@hugovk@AA-Turner